feat(api): add delete model run endpoint#268
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
hey guys @kaylawilding @mrmaloof, I was under the impression that we were just archiving these models, not deleting them completely from the DB. I'm also seeing here that we're deleting files as well from the backend? I don't think we want to do either. What's the behavioral spec say? |
We're deleting model runs, not models my mistake. We're good. |
|
@kaylawilding @mrmaloof Okay I looked more into this, we're only deleting the inference output files. So I think we're safe here. Though I would feel more comfortable that we tested this on dev properly and made sure the cleanup looks good (we're not missing anything or deleting anything we shouldn't). I can test this. |
|
@mrmaloof heads up, tested the endpoint, and it works well. I'm patching the "run_id" naming issue, since this is a "job_run_id" and could be confused with "model_run_id". We have several other endpoints here that need this fixed. I'll chat about this in our team meeting. |
Description
DELETE /institutions/{inst_id}/models/{model_name}/run/{run_id}to remove a completed model runmodelsandrunsfromlocal_inst_data.jsonAsana Task
EDVISEBUILD-5001 - Add delete option to "model run history" page for DataKinders
Deployment Readiness*
Testing
Describe or check:
Deployment Notes
Describe or check:
Rollback Plan
Describe or check:
git revert)Reviewer Guidance / Questions*
Screenshots / Testing Evidence*
SOC 2 Change Management Checklist
./vendor/bin/pest)Provide justification if you are submitting a PR with any boxes checked other than the first.
Reminder for Reviewers: By approving this PR you are confirming that you have reviewed the code for correctness, security, and compliance with our engineering and SOC 2 standards. Do not approve PRs where SOC 2 checklist items are checked without documented justification.
*Optional