Skip to content

[CFX-5560] chore: new task delint to fix lints#422

Merged
ajalon1 merged 5 commits intodatarobot-oss:mainfrom
ajalon1:aj/lint-fix
Apr 8, 2026
Merged

[CFX-5560] chore: new task delint to fix lints#422
ajalon1 merged 5 commits intodatarobot-oss:mainfrom
ajalon1:aj/lint-fix

Conversation

@ajalon1
Copy link
Copy Markdown
Contributor

@ajalon1 ajalon1 commented Apr 6, 2026

RATIONALE

I want a way to fix as many lint issues as possible. lint does some already, but I know golangci-lint can fix issues, so let's do that too.

Let's actually do that in a new delint task, and leave lint as is.

CHANGES

task delint
golangci-lint run --fix
simplify AGENTS.md
update dev docs

PR Automation

Comment-Commands: Trigger CI by commenting on the PR:

  • /trigger-smoke-test or /trigger-test-smoke - Run smoke tests
  • /trigger-install-test or /trigger-test-install - Run installation tests

Labels: Apply labels to trigger workflows:

  • run-smoke-tests or go - Run smoke tests on demand (only works for non-forked PRs)

Important

For Forked PRs: If you're an external contributor, the run-smoke-tests label won't work. A maintainer must manually trigger the "Fork PR Smoke Tests" workflow from the Actions tab, providing your PR number. Please comment requesting a maintainer review if you need smoke tests to run.


Note

Low Risk
Low risk: changes are limited to developer tooling/docs and do not affect runtime CLI behavior. Main impact is local/CI workflows now using task lint for non-modifying checks and task delint for auto-fixes.

Overview
Splits linting into check-only task lint and auto-fixing task delint, making lint non-modifying (uses go mod tidy -diff, gofumpt -d, golangci-lint run, and goreleaser check) while delint runs formatting/dependency cleanup and golangci-lint run --fix.

Updates dev-init to depend on delint and refreshes AGENTS.md to document the new task semantics and recommended workflow (run delint to fix, then lint to verify).

Reviewed by Cursor Bugbot for commit d28716d. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit b228122. Configure here.

Comment thread Taskfile.yaml
Copy link
Copy Markdown
Contributor

@c-h-russell-walker c-h-russell-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thank you for this.

Question though - won't linting in CI pass even if there's then unstaged changes?

Maybe make an additional task command called like delint or lint-fix ?

@ajalon1
Copy link
Copy Markdown
Contributor Author

ajalon1 commented Apr 6, 2026

Great point. I was wondering why we didn't have a lint-fix or delint.

Let me pull this back into draft and add a task delint, and then update the lint workflow and docs.

@ajalon1 ajalon1 changed the title chore: task lint will now fix lints chore: new task delint to fix lints Apr 6, 2026
@ajalon1 ajalon1 requested a review from a team April 7, 2026 00:00
@ajalon1 ajalon1 changed the title chore: new task delint to fix lints [CFX-5560] chore: new task delint to fix lints Apr 7, 2026
Copy link
Copy Markdown
Contributor

@c-h-russell-walker c-h-russell-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

@ajalon1 ajalon1 merged commit b6e9c62 into datarobot-oss:main Apr 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants