[CFX-5557] tweak templates setup timeouts#424
Open
ajalon1 wants to merge 4 commits intodatarobot-oss:mainfrom
Open
[CFX-5557] tweak templates setup timeouts#424ajalon1 wants to merge 4 commits intodatarobot-oss:mainfrom
ajalon1 wants to merge 4 commits intodatarobot-oss:mainfrom
Conversation
Contributor
|
🔐 Fork smoke tests started by maintainer ⏳ Security scans passed. Running smoke tests... Commit: |
Contributor
Author
Contributor
|
✅ All smoke tests passed! (Fork PR) ✅ Security Scan: success |
c-h-russell-walker
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RATIONALE
Flaky test now: https://github.com/datarobot-oss/cli/actions/runs/24057232285/attempts/1
But it succeeded on the second try: https://github.com/datarobot-oss/cli/actions/runs/24057232285
I think its because I changed timeouts to 30s for Phase 0, but that's not really necessary. Let's see if the previous value of 360s works here.
CHANGES
PR Automation
Comment-Commands: Trigger CI by commenting on the PR:
/trigger-smoke-testor/trigger-test-smoke- Run smoke tests/trigger-install-testor/trigger-test-install- Run installation testsLabels: Apply labels to trigger workflows:
run-smoke-testsorgo- Run smoke tests on demand (only works for non-forked PRs)Important
For Forked PRs: If you're an external contributor, the
run-smoke-testslabel won't work. A maintainer must manually trigger the "Fork PR Smoke Tests" workflow from the Actions tab, providing your PR number. Please comment requesting a maintainer review if you need smoke tests to run.Note
Low Risk
Low risk: only changes an Expect timeout in smoke-test automation to reduce flakiness; no product/runtime logic is affected.
Overview
Reduces smoke-test flakiness in
smoke_test_scripts/expect_templates_setup.expby removing the shortened Phase 0 timeout, allowing the existing longer timeout to cover the Pulumi pre-wizard flow before the dotenv wizard starts.Reviewed by Cursor Bugbot for commit 1827237. Bugbot is set up for automated code reviews on this repo. Configure here.