Repository navigation
[codex] verify image artifact checksum - #113
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
davidiach
commented
May 11, 2026
davidiach
left a comment
Owner
Author
There was a problem hiding this comment.
Self-review pass in progress.
Current checks:
- Manifest generation runs from inside
build, soSHA256SUMSpoints atllmos.img, matching the artifact extraction directory. - The upload still runs with
success() || failure()to preserve diagnostic image uploads after late failures. - Download and verification use normal success gating through the explicit
steps.upload-image.outcome == 'success'expression, so unrelated failed checks do not cause noisy secondary artifact failures.
Local validation is green: git diff --check -- .github/workflows/build.yml, wsl.exe -d Ubuntu make ci-check, and a WSL checksum copy simulation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build/SHA256SUMSforllmos.imgafter CI image checksllmos.imgWhy
The workflow uploaded the bootable image artifact without a payload-level checksum. Adding a manifest makes downloaded artifacts independently verifiable, and the in-workflow download/check verifies the uploaded artifact layout matches the manifest.
Review notes
build/, so it recordsllmos.imgrather thanbuild/llmos.img; this matches the extracted artifact layout.success() || failure()and only runs whenbuild/llmos.imgexists.Validation
git diff --check -- .github/workflows/build.ymlwsl.exe -d Ubuntu make ci-checkbuild/SHA256SUMS, verify it, copyllmos.imgplusSHA256SUMSto a clean directory, and verify again withsha256sum -c