fix(tests): unblock AudioProcessingTrack recv() silence tests#1022
Merged
fix(tests): unblock AudioProcessingTrack recv() silence tests#1022
Conversation
After PR #1001 ("Delay A/V in WebRTC until both tracks have been seen."), AudioProcessingTrack.recv() now blocks in _wait_for_initial_audio() on its first call until enough audio has been buffered. Three tests still constructed tracks with started=False and fed no/insufficient/paused audio, so recv() looped forever, causing CI runs to time out at ~2h. Drop started=False from the silence-fallback tests so they exercise the post-anchor path, which is what these assertions actually cover. Local pytest now completes in ~70s. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Rafał Leszko <rafal@livepeer.org>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
🚀 fal.ai Preview Deployment
Testing on Cloud |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AudioProcessingTrack.recv()so the first call now blocks in_wait_for_initial_audio()until enough audio has been buffered, but three tests intests/test_audio_processing_track.pystill constructed tracks withstarted=Falseand fed no / insufficient / paused audio — sorecv()looped forever.started=Falsefrom the silence-fallback tests (test_no_audio_returns_silence,test_paused_returns_silence,test_undersized_chunk_returns_silence) so they exercise the post-anchorrecv()path, which is the path these silence-fallback assertions actually care about.pytestnow completes in ~70s instead of hanging.Test plan
uv run pytest tests/test_audio_processing_track.py -v— 30/30 pass in ~1.2suv run pytest— full suite completes in ~70s (vs. previously hanging ontest_no_audio_returns_silence)uv run ruff check tests/test_audio_processing_track.pycleanuv run ruff format --check tests/test_audio_processing_track.pyclean🤖 Generated with Claude Code