docs(transcript-fixer): the reviewer's decision_note is an instruction, and nothing promotes it - #255
Open
daymade wants to merge 1 commit into
Open
docs(transcript-fixer): the reviewer's decision_note is an instruction, and nothing promotes it#255daymade wants to merge 1 commit into
daymade wants to merge 1 commit into
Conversation
…n, and nothing promotes it
A reviewer overrode a suggestion and attached the reason — a rule about a whole
class of substitutions, worth far more than the one edit it rode in on. The edit
was recorded; the rule reached nothing, and the next session re-flagged the same
class. The tooling was working correctly the whole time: the dashboard's 备注 box
(app.js:160) shells to the CLI's --note, which writes decision_note
(review_queue.py:668). SKILL.md taught agents how to WRITE that column and never
once how to read it, let alone promote it.
Adds one section to Review Queue & Dashboard covering:
- Where the note hides: the human-readable --show-review gates it behind
`status != pending`, while --json carries the key unconditionally — and the
agent path here IS --json, so it was always reachable.
- Which verdicts to sweep: kept_original specifically. A "this class is
deliberate, stop flagging it" note lands on exactly that verdict, and the
status filter in the neighbouring text-propagation sweep (accepted|overridden)
misses every one of them.
- Routing by what the note SAYS. Four-row table, because the exits are not
interchangeable and the obvious-looking one is backwards: for "stop flagging
this", --add is the exact opposite — it creates a rule that rewrites the text
from then on. Context-file trap line is the right exit; --report-false-positive
is for a misfiring dictionary rule; the roster is hand-edited with no CLI.
Independent review (fresh-context, non-fork, read-only) caught two real defects
in the first draft, both on one sentence — the sharper one being that the exit I
had pointed at, the append_note action, runs only on ACCEPT and is dropped by
design on overridden (SKILL.md:258-260), which is precisely the verdict the
motivating example used. Readers were being sent to an exit the system discards
in the exact scenario described. Also fixed: a false universal ("a verdicted item
is the only place the note exists" — _reopen writes the note while sending the
item back to pending, review_queue.py:708), the --show-review/--json precision,
and the missing kept_original command. 7/7 findings adopted; review archived in
the author's private notes repo.
Five other candidates from the same session were dropped by the verify-first
rule: the local plugin cache is 1.16.2, 128 lines behind source, and the source
already covers them — including "One verdict fixes one occurrence" (SKILL.md:333),
which documents the exact residue I had just measured, with better data than I
had. Without that check this commit would have shipped a duplicate.
Gates: quick_validate ok; regression audit 0 candidates / 2669 exact
preservations (pure addition); security_scan passed, plus a manual Layer-4
read-through since its keyword pass cannot see CJK names or verbatim transcript
lines. daymade-audio 1.18.0 → 1.18.1. scripts/ deliberately untouched — a
parallel session is actively working cli/ and core/ there.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gap
A reviewer overrode a suggestion and attached the reason — a rule about a whole class of substitutions, worth far more than the single edit it rode in on. The edit was recorded; the rule reached nothing, and the next session re-flagged the same class.
The tooling was working correctly the entire time:
SKILL.mdtaught agents how to write that column and never once how to read it, let alone promote it. This skill's whole premise is that corrections compound; an explanation that stays indecision_noteis the one kind of knowledge here that provably does not.What the section adds
--show-reviewgates it behindstatus != pending, while--jsoncarries the key unconditionally. Since the agent path here is--json, it was always reachable.kept_originalspecifically. A "this class is deliberate, stop flagging it" note lands on exactly that verdict, and the status filter used by the neighbouring text-propagation sweep (accepted|overridden) misses every one of them.--addis the exact opposite — it creates a rule that rewrites the text from then on.Independent review found two real defects in the first draft
Both on one sentence. The sharper one: the exit I had pointed at — the
append_noteaction — runs only onacceptand is dropped by design onoverridden(SKILL.md:258-260), which is precisely the verdict the motivating example used. Readers were being sent to an exit the system discards in the exact scenario described.Also fixed: a false universal ("a verdicted item is the only place the note exists" —
_reopenwrites the note while sending the item back topending,review_queue.py:708), the--show-review/--jsonprecision, and the missingkept_originalcommand. 7/7 findings adopted.Five other candidates were dropped by verify-first
The local plugin cache is 1.16.2, 128 lines behind source, and the source already covers them — including
One verdict fixes one occurrence(SKILL.md:333), which documents the exact residue I had just measured, with better data than I had. Without that check this PR would have shipped a duplicate.Gates
quick_validatesecurity_scandaymade-audio1.18.0 → 1.18.1scripts/deliberately untouched — a parallel session is actively workingcli/andcore/there.🤖 Generated with Claude Code