Working extract-tables for multi-statement inputs #1227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Appears to close #1066 as well. |
using an unholy combination of sqlparse and sqlglot. sqlparse is more lenient and can chop up multiple statements even though it doesn't understand "\T". sqlglot is stricter, and chokes when it sees "\T", but is better at the simple task of extracting table names from a valid statement, and provides a much better interface. We could also use sqlglot.tokenize() and split on the semicolon token, which would be more verbose. Closes #1122, in which the table name was always given as "DUAL" when multiple statements were in the same input leading with "\T sql-insert".
rolandwalker
force-pushed
the
RW/extract-tables-from-multiple-statements
branch
from
129a8b2 to
1acbfdb
Compare
amjith
approved these changes
Apr 30, 2025
Member
amjith
left a comment
amjith
left a comment
There was a problem hiding this comment.
Wow. That is an interesting approach.
Contributor
Author
|
I think a tree-sitter grammar could be even better at covering all the cases with one tool. In my experience tree-sitter is especially good at best-effort parsing of erroneous or partial data, which makes sense since it was developed for syntax highlighting in an editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Working extract-tables for multi-statement inputs, using an unholy combination of sqlparse and sqlglot.
sqlparse is more lenient and can chop up multiple statements even though it doesn't understand
\T. sqlglot is stricter, and chokes when it sees\T, but is better at the simple task of extracting table names from a valid statement, and provides a much better interface.We could also use
sqlglot.tokenize()and split on the semicolon token, which would be more verbose.Closes #1122, in which the table name was always given as
DUALwhen multiple statements were in the same input leading with\T sql-insert.Checklist
changelog.md.AUTHORSfile (or it's already there).