fix crash caused by setting nil to a primitive attribute.#81
Open
khaledannajar wants to merge 1 commit intodchohfi:masterfrom
Open
fix crash caused by setting nil to a primitive attribute.#81khaledannajar wants to merge 1 commit intodchohfi:masterfrom
khaledannajar wants to merge 1 commit intodchohfi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a wrong value "null" is set to a primitive attribute in the JSON and the DCAttributeSetter try to assign it to the attribute a crash is thrown
Here in this sample JSON book_id in int type and is set to null here I get the crash saying something like that " setNilValueForKey]: could not set nil as the value for the key _book_id.' ":
I fixed it by simply setting @0 to this special case.
{
"name": "andro",
"avatar": "http://url/userimage.jpg",
"summary": "pla pla pla ",
"book_id": null,
"datetime": 1455714077
}