[codex] Fix Claude macOS PTY isolation with experimental ptyHost#165
Merged
[codex] Fix Claude macOS PTY isolation with experimental ptyHost#165
Conversation
faa4ca2 to
33d821c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the macOS Claude PTY fix and introduces the experimental ptyHost path behind the existing settings checkbox /
PANE_USE_PTY_HOST=1flag.Changes include:
sh -c 'exec ...'to reduce inherited Electron process state for Claude Code v2.1.113+.main/src/ptyHost/*UtilityProcess RPC host for PTY spawn/write/resize/kill/pause/resume/ack.Follow-up
Tracked in #164:
Validation
pnpm --filter main exec vitest run src/ptyHost/flowControl.test.tspnpm typecheckpnpm lintNotes:
>=22.14.0; current shell is Nodev20.19.3.pnpm lintpasses with existing warnings.PANE_USE_PTY_HOST=1.