Fix tests - #34
Merged
Merged
Conversation
Despite "select-dom" having types, for some reason they don't get picked up properly and after about 2h trying to figure out a better way to fix, I decided to run ts-jest with a tsconfig with '"noImplicitAny": false'.
Since especially SourceForge and BitBucket take a lot of time to render (needed for the selector tests), there will be less 'random' failing when waiting longer for the proper render.
on demand by a click in the github web GUI
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 16.85% 16.85%
=======================================
Files 19 19
Lines 362 362
Branches 47 47
=======================================
Hits 61 61
Misses 299 299
Partials 2 2
Continue to review full report at Codecov.
|
Owner
|
@s-weigand Thank you very much ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rebasing #25 I saw that the CI tests are broken.
This happened due to a change in the version of
select-dom, which for some reason doesn't work nicely withts-jest.github-vscode-icons/package.json
Line 64 in ee4a667
Also for the page selector tests to not fail kinda randomly (connection timeout), I raised the max timeout limit for rendering the pages from 5s (jest default) to 30s.
That way the scheduled tests shouldn't span you due to connection timeouts that often (hopefully no false positives at all anymore).