Skip to content

Makes DDPageControl pixel-match UIPageControl #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Makes DDPageControl pixel-match UIPageControl #7

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1fd04b
Tweak sizing and spacing to match defaults of UIPageControl
cbowns Jun 5, 2012
f2b72ff
UIPageControl's inactive image is white:1.0 alpha:0.3
cbowns Jun 5, 2012
4417891
Default values now pixel-match UIPageControl
cbowns Jun 5, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions Classes/DDPageControl.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
#import "DDPageControl.h"


#define kDotDiameter 4.0f
#define kDotSpace 12.0f
#define kDotDiameter 5.0f
#define kDotSpace 11.0f


@implementation DDPageControl
Expand Down Expand Up @@ -83,10 +83,11 @@ - (void)drawRect:(CGRect)rect
CGFloat dotsWidth = self.numberOfPages * diameter + MAX(0, self.numberOfPages - 1) * space ;
CGFloat x = CGRectGetMidX(currentBounds) - dotsWidth / 2 ;
CGFloat y = CGRectGetMidY(currentBounds) - diameter / 2 ;
y += 0.5f; // Bump down to match UIPageControl

// get the caller's colors it they have been set or use the defaults
UIColor *drawOnColor = onColor ? onColor : [UIColor colorWithWhite: 1.0f alpha: 1.0f];
UIColor *drawOffColor = offColor ? offColor : [UIColor colorWithWhite: 0.7f alpha: 0.5f];
UIColor *drawOffColor = offColor ? offColor : [UIColor colorWithWhite: 1.0f alpha: 0.3f];

// actually draw the dots
for (int i = 0 ; i < numberOfPages ; i++)
Expand Down Expand Up @@ -282,4 +283,4 @@ - (void)touchesEnded:(NSSet *)touches withEvent:(UIEvent *)event
[self sendActionsForControlEvents: UIControlEventValueChanged] ;
}

@end
@end