Improve/release workflow#5
Merged
Merged
Conversation
- Replace `generate_release_notes: true` with an awk-based extraction of the matching `## [VERSION]` section from CHANGELOG.md. Embedding the section content sidesteps GitHub's date-sensitive anchor generation (e.g. `030---2026-05-29`) so release notes stay correct regardless of when the tag is cut. Fails the job if no matching section is found, surfacing missing CHANGELOG entries early. - Append an Artifacts block that points library users at Maven Central with a ready-to-paste coordinate, and notes that the wizard uber-jar is the only attached download (it is excluded from Central deploys). - Fix the wizard jar glob: the shade plugin writes `didwebvh-wizard/target/didwebvh-wizard.jar` (no version, no `-shaded` classifier), so the previous `*-shaded.jar` pattern matched nothing and broke release uploads. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
The README directs users at the aggregate `didwebvh-java` artifact (pom.xml:8), which transitively brings in `didwebvh-core` and `didwebvh-signing-local`. Release notes were recommending `didwebvh-core` alone, which is the right call only when supplying a custom `Signer`. Lead with the aggregate, mention `didwebvh-core` as the BYO-Signer alternative — matching README.md:35-47 exactly. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Lift didwebvh-core coverage from ~84% to ~91% by exercising real behaviour: - LogChainValidator: malformed versionId, malformed versionTime (with a properly-rehashed entry so the parse step is actually reached), last-entry versionTime > now+60s rejection, and witness threshold = 0 rejection. - DidResolver: invalid versionNumber query → invalidDid, versionTime query selector honoured, PROACTIVE witness fetch (success / swallowed notFound / non-notFound rethrow), WHEN_REQUIRED with missing witness → "Witness proofs are required" mapped to invalidDid, and the resolveFromLog(rawJsonl, did) overload. - FileDidFetcher: null-path → invalidDid and missing file → notFound error-code mapping. - Jcs: malformed JSON wraps IOException as ValidationException.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
…te, URL Raise didwebvh-core Codecov coverage from ~77% to ~82% (line coverage 93%) by adding branch-targeted tests on meaningful spec behaviour. Locally measured codecov-equivalent ratio (hits / (hits + misses + partial branches)). - LogChainValidator: first-entry missing scid / missing updateKeys, method-version downgrade rejection (exercises compareMethod / extractMethodVersion). - LogProcessor: empty/blank log content, malformed JSONL entry, unknown versionId/versionNumber selectors, malformed versionTime query, versionTime before first entry, malformed witness proofs. - MigrateDidOperation: null existingState/signer/newDomain, empty newDomain, deactivated-DID rejection, newPath path-segment appending, alsoKnownAs duplicate skip. - CreateDidOperation: controllers list omitted/single/array forms; extractMultikey for bare did:key VM and rejection of non-did:key verification methods. - DidWebVhUrl: empty domain, port out of range, non-numeric port, bracketed IPv6 host, '=' less query param, multi-param toString. - CHANGELOG: rewrite the v0.3.0 coverage entry to reflect the Codecov-metric numbers and scope.
swcurran
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_release_notes: truewith an awk-based extractionof the matching
## [VERSION]section from CHANGELOG.md. Embeddingthe section content sidesteps GitHub's date-sensitive anchor
generation (e.g.
030---2026-05-29) so release notes stay correctregardless of when the tag is cut. Fails the job if no matching
section is found, surfacing missing CHANGELOG entries early.
with a ready-to-paste coordinate, and notes that the wizard uber-jar
is the only attached download (it is excluded from Central deploys).
didwebvh-wizard/target/didwebvh-wizard.jar(no version, no-shadedclassifier), so the previous*-shaded.jarpattern matchednothing and broke release uploads.