Skip to content

Conversation

@loktev-d
Copy link
Contributor

@loktev-d loktev-d commented Nov 24, 2025

Description

Implements d8v prefixing for VirtualMachineSnapshot and VirtualDiskSnapshot service resources according to the ADR for consistent naming across the virtualization module.

Key changes:

  • VMS Secret: Changed from <name> to d8v-vms-<name>-<uid> format
  • VDS VolumeSnapshot: Changed from <name> to d8v-vds-<name>-<uid> format
  • Added CommonSupplement() method to supplements.Generator
  • Resources are now fetched using status fields (.Status.VirtualMachineSnapshotSecretName and .Status.VolumeSnapshotName)

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmsnapshot
type: feature
summary: add d8v prefix to snapshot supplemental resources

Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d changed the title feat(vmsnapshot, vdsnapshot, vmrestore): add d8v prefix to service resources feat(vmsnapshot, vdsnapshot): add d8v prefix to service resources Nov 24, 2025
loktev-d and others added 8 commits November 24, 2025 11:42
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d changed the title feat(vmsnapshot, vdsnapshot): add d8v prefix to service resources feat(vmsnapshot, vdsnapshot): add d8v prefix to snapshot supplemental resources Nov 24, 2025
@loktev-d loktev-d added this to the v1.2.0 milestone Nov 24, 2025
Isteb4k
Isteb4k previously approved these changes Nov 24, 2025
Signed-off-by: Daniil Loktev <[email protected]>
@loktev-d loktev-d added the e2e/run Run e2e test on cluster of PR author label Nov 24, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 24, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 24, 2025
Signed-off-by: Daniil Loktev <[email protected]>
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants