Skip to content

fix(images): make importers work in tainted cluster #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(images): make importers work in tainted cluster #1747

wants to merge 1 commit into from

Conversation

@diafour
Copy link
Member

@diafour diafour commented Nov 25, 2025 •
edited
Loading

Description

  • Add toleration to run importers on nodes belong to NodeGroup/system.
  • Add toleration to CDI config for DV workload Pods (importers, uploaders, preps, etc.).
  • vd contoller: move InUse handler before Lifecycle handler. Lifecycle handler can see "attached to" vm in status and copy tolerations from it.

Why do we need it, and what problem does it solve?

It is not possible to create images and disks with datasource in cluster where all nodes have taints.

What is the expected result?

FOCUS=VirtualImageCreation task e2e:run runs on tainted cluster

Ran 1 of 183 Specs in 434.664 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 182 Skipped
PASS

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: images
type: fix
summary: Make images importers work in tainted cluster

@diafour diafour added this to the v1.2.0 milestone Nov 25, 2025
@diafour diafour marked this pull request as draft November 26, 2025 07:21
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
@diafour diafour marked this pull request as ready for review November 27, 2025 08:09
@diafour diafour requested a review from fl64 as a code owner November 27, 2025 08:09
eofff
eofff requested changes Nov 27, 2025
View reviewed changes
@diafour diafour force-pushed the fix/images/toleration-system-nodes-for-importer-pods branch from ca47f3d to 2ab0e13 Compare December 1, 2025 11:40
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 1, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 1, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 1, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 1, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 1, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 1, 2025
@diafour
fix(images): make importers work in tainted cluster
ec01193 
- Add toleration to run importers on nodes belong to NodeGroup/system.

Signed-off-by: Ivan Mikheykin <[email protected]>
@diafour diafour force-pushed the fix/images/toleration-system-nodes-for-importer-pods branch from 2ab0e13 to ec01193 Compare December 2, 2025 07:09
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@diafour diafour added the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
@diafour diafour added build/github/ubuntu Run jobs on github runners e2e/run Run e2e test on cluster of PR author labels Dec 2, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 2, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eofff eofff eofff requested changes

@Isteb4k Isteb4k Awaiting requested review from Isteb4k Isteb4k is a code owner

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@LopatinDmitr LopatinDmitr Awaiting requested review from LopatinDmitr

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@diafour diafour

Labels

build/github/ubuntu Run jobs on github runners

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@diafour @deckhouse-BOaTswain @eofff @Isteb4k