fix(vmrestore): vmbda fail #1759
Draft
+67
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danilrwx
force-pushed
the
fix/vmrestore/vmbda-fail
branch
5 times, most recently
from
f181a56 to
4942937
Compare
danilrwx
added
delve/virt-handler
This reverts commit c1e6c5f. Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
Signed-off-by: Daniil Antoshin <[email protected]>
danilrwx
force-pushed
the
fix/vmrestore/vmbda-fail
branch
2 times, most recently
from
7b4d9ea to
0486e0c
Compare
danilrwx
force-pushed
the
fix/vmrestore/vmbda-fail
branch
from
2ae90cd to
0486e0c
Compare
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
Contributor
|
Workflow has started. The target step completed with status: failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cycle set cgroups by done it once after all mounts.
Why do we need it, and what problem does it solve?
Solves the problem when cgroummanager.Set is called in the next reconcile and resets the permissions on the block hotplug file. Before the fix, the first cgroummanager.Set was called only for the current device, now it will be called after all mounts immediately for all devices.
Checklist