Update inner node builder to require two children#73
Merged
Conversation
**Description** In a prior commit, I added a builder for creating inner nodes that guaranteed at least a single child. I realized later that I hadn't gone far enough, all inner nodes actually require at least two children! This commit updates the builder to add another type-state, modifies tests to pass this new requirement. **Motivation** In a separate branch I've been experimenting with some optimizations and one of those optimizations had a requirement that the inner node had at least two children. That made me remember the builder stuff and I figured it would be good to actually bring it up the real requirement. **Testing Done** Modified existing tests, no new, all passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In a prior commit, I added a builder for creating inner nodes that
guaranteed at least a single child. I realized later that I hadn't
gone far enough, all inner nodes actually require at least two children!
This commit updates the builder to add another type-state, modifies tests
to pass this new requirement.
Motivation
In a separate branch I've been experimenting with some optimizations and
one of those optimizations had a requirement that the inner node had at
least two children. That made me remember the builder stuff and I
figured it would be good to actually bring it up the real requirement.
Testing Done
Modified existing tests, no new, all passed.