Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Documentation/admin-guide/mm/zswap.rst
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,16 @@ attribute, e. g.::

Setting this parameter to 100 will disable the hysteresis.

When there is a sizable amount of cold memory residing in the zswap pool, it
can be advantageous to proactively write these cold pages to swap and reclaim
the memory for other use cases. By default, the zswap shrinker is disabled.
User can enable it as follows:

echo Y > /sys/module/zswap/parameters/shrinker_enabled

This can be enabled at the boot time if ``CONFIG_ZSWAP_SHRINKER_DEFAULT_ON`` is
selected.

A debugfs interface is provided for various statistic about pool size, number

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (typo): Use the plural "statistics" instead of "statistic".

Because this covers multiple metrics (pool size, number of pages, etc.), "various statistic" should be "various statistics".

Suggested change
A debugfs interface is provided for various statistic about pool size, number
A debugfs interface is provided for various statistics about pool size, number

of pages stored, same-value filled pages and various counters for the reasons
pages are rejected.
2 changes: 2 additions & 0 deletions include/linux/mmzone.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
#include <linux/mm_types.h>
#include <linux/page-flags.h>
#include <linux/local_lock.h>
#include <linux/zswap.h>
#include <linux/deepin_kabi.h>
#include <asm/page.h>

Expand Down Expand Up @@ -644,6 +645,7 @@ struct lruvec {
#ifdef CONFIG_MEMCG
struct pglist_data *pgdat;
#endif
struct zswap_lruvec_state zswap_lruvec_state;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

竟然没破坏白名单内的KABI,说明当初白预留了......

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

竟然没破坏白名单内的KABI,说明当初白预留了......

有破坏再修复

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

竟然没破坏白名单内的KABI,说明当初白预留了......

DEEPIN_KABI_RESERVE(1)
DEEPIN_KABI_RESERVE(2)
DEEPIN_KABI_RESERVE(3)
Expand Down
25 changes: 23 additions & 2 deletions include/linux/zswap.h
Original file line number Diff line number Diff line change
Expand Up @@ -5,20 +5,40 @@
#include <linux/types.h>
#include <linux/mm_types.h>

struct lruvec;

extern u64 zswap_pool_total_size;
extern atomic_t zswap_stored_pages;

#ifdef CONFIG_ZSWAP

struct zswap_lruvec_state {
/*
* Number of pages in zswap that should be protected from the shrinker.
* This number is an estimate of the following counts:
*
* a) Recent page faults.
* b) Recent insertion to the zswap LRU. This includes new zswap stores,
* as well as recent zswap LRU rotations.
*
* These pages are likely to be warm, and might incur IO if the are written
* to swap.
*/
atomic_long_t nr_zswap_protected;
};

bool zswap_store(struct folio *folio);
bool zswap_load(struct folio *folio);
void zswap_invalidate(int type, pgoff_t offset);
void zswap_swapon(int type);
void zswap_swapoff(int type);
void zswap_memcg_offline_cleanup(struct mem_cgroup *memcg);

void zswap_lruvec_state_init(struct lruvec *lruvec);
void zswap_page_swapin(struct page *page);
#else

struct zswap_lruvec_state {};

static inline bool zswap_store(struct folio *folio)
{
return false;
Expand All @@ -33,7 +53,8 @@ static inline void zswap_invalidate(int type, pgoff_t offset) {}
static inline void zswap_swapon(int type) {}
static inline void zswap_swapoff(int type) {}
static inline void zswap_memcg_offline_cleanup(struct mem_cgroup *memcg) {}

static inline void zswap_lruvec_state_init(struct lruvec *lruvec) {}
static inline void zswap_page_swapin(struct page *page) {}
#endif

#endif /* _LINUX_ZSWAP_H */
14 changes: 14 additions & 0 deletions mm/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,20 @@ config ZSWAP_EXCLUSIVE_LOADS_DEFAULT_ON
The cost is that if the page was never dirtied and needs to be
swapped out again, it will be re-compressed.

config ZSWAP_SHRINKER_DEFAULT_ON
bool "Shrink the zswap pool on memory pressure"
depends on ZSWAP
default n
help
If selected, the zswap shrinker will be enabled, and the pages
stored in the zswap pool will become available for reclaim (i.e
written back to the backing swap device) on memory pressure.

This means that zswap writeback could happen even if the pool is
not yet full, or the cgroup zswap limit has not been reached,
reducing the chance that cold pages will reside in the zswap pool
and consume memory indefinitely.

choice
prompt "Default compressor"
depends on ZSWAP
Expand Down
1 change: 1 addition & 0 deletions mm/mmzone.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ void lruvec_init(struct lruvec *lruvec)

memset(lruvec, 0, sizeof(struct lruvec));
spin_lock_init(&lruvec->lru_lock);
zswap_lruvec_state_init(lruvec);

for_each_lru(lru)
INIT_LIST_HEAD(&lruvec->lists[lru]);
Expand Down
2 changes: 2 additions & 0 deletions mm/swap_state.c
Original file line number Diff line number Diff line change
Expand Up @@ -698,6 +698,7 @@ struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t gfp_mask,
&page_allocated, false);
if (unlikely(page_allocated))
swap_readpage(page, false, NULL);
zswap_page_swapin(page);
return page;
}

Expand Down Expand Up @@ -873,6 +874,7 @@ static struct page *swap_vma_readahead(swp_entry_t targ_entry, gfp_t gfp_mask,
&page_allocated, false);
if (unlikely(page_allocated))
swap_readpage(page, false, NULL);
zswap_page_swapin(page);
return page;
}

Expand Down
Loading