[Deepin-Kernel-SIG] [linux 6.6.y] net: wangxun: ngbe: Guard ngbe_netpoll with CONFIG_NET_POLL_CONTROLLER

[opsiff]

When CONFIG_NET_POLL_CONTROLLER is disabled, ngbe_netpoll() is compiled in but never referenced, as the ndo_netpoll assignment is already guarded by the same config. This triggers an unused-function warning (-Wunused-function).

Wrap the function definition in #ifdef CONFIG_NET_POLL_CONTROLLER to match its usage.

Fixes: 4d60408 ("deepin: net: wangxun: ngbe: add support for wangxun 1G")
Reported-by: WangYuli wangyl5933@chinaunicom.cn

Summary by Sourcery

Bug Fixes:

• Prevent an unused-function warning by only compiling ngbe_netpoll when CONFIG_NET_POLL_CONTROLLER is enabled.

[deepin-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from opsiff. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Wraps the ngbe_netpoll() implementation in a CONFIG_NET_POLL_CONTROLLER guard so that the function is only compiled when net polling is enabled, eliminating an unused-function warning and aligning the definition with its conditional usage.

Flow diagram for CONFIG_NET_POLL_CONTROLLER guarding ngbe_netpoll compilation

flowchart TD
    CONFIG[CONFIG_NET_POLL_CONTROLLER]
    NETPOLL_DEF[ngbe_netpoll function definition]
    NETPOLL_NDO[ndo_netpoll assignment]

    CONFIG -->|enabled| NETPOLL_DEF
    CONFIG -->|enabled| NETPOLL_NDO
    CONFIG -->|disabled| SKIP_DEF[skip ngbe_netpoll definition]
    CONFIG -->|disabled| SKIP_NDO[skip ndo_netpoll assignment]

    NETPOLL_DEF --> NETPOLL_NDO

Loading

File-Level Changes

Change	Details	Files
Guard the ngbe_netpoll() function definition with CONFIG_NET_POLL_CONTROLLER to match its conditional usage and avoid -Wunused-function warnings when net polling support is disabled.	Added a #ifdef CONFIG_NET_POLL_CONTROLLER before the ngbe_netpoll() function comment and signature. Added a corresponding #endif after the ngbe_netpoll() function body to close the configuration guard. Kept the existing netpoll logic (calling ngbe_intr when adapter interrupts are enabled) unchanged inside the new guard.	drivers/net/ethernet/wangxun/ngbe/ngbe_main.c

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've reviewed your changes and they look great!

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}