refactor: find scalapack automatically#7235
Open
Cstandardlib wants to merge 2 commits intodeepmodeling:developfrom
Open
refactor: find scalapack automatically#7235Cstandardlib wants to merge 2 commits intodeepmodeling:developfrom
Cstandardlib wants to merge 2 commits intodeepmodeling:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors ScaLAPACK detection to rely on the project’s FindScaLAPACK.cmake and removes the previous SCALAPACK_LIBRARY_DIR override path, aligning configuration with the expected SCALAPACK_DIR “prefix directory” convention (Fix #7232).
Changes:
- Removes the custom
SCALAPACK_LIBRARY_DIRhandling/validation and associated fallback logic. - Always uses
find_package(ScaLAPACK REQUIRED)and links viaScaLAPACK::ScaLAPACK.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Fix #7232
What's changed?
cmake/FindScaLAPACK.cmake.SCALAPACK_DIRis the directory containing the libraryscalapack/scalapack-openmpi.SCALAPACK_LIBRARY_DIRvariable to specify the library file itself.