refactor: Add empty() method to TagSet and use it for emptiness checks#377
Open
yurekami wants to merge 1 commit into
Open
refactor: Add empty() method to TagSet and use it for emptiness checks#377yurekami wants to merge 1 commit into
yurekami wants to merge 1 commit into
Conversation
Add empty() method to TagSet class for consistent container interface and replace .size() > 0 checks with !.empty() in ScopedMetricsWriter. This follows the clang-tidy readability-container-size-empty guideline which recommends using empty() instead of comparing size() to zero. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
empty()method toTagSetclass for consistent container interface.size() > 0checks with!.empty()inScopedMetricsWriterMotivation
This follows the clang-tidy
readability-container-size-emptyguideline which recommends usingempty()instead of comparingsize()to zero.Benefits:
!.empty()is more idiomatic and clearer than.size() > 0TagSetwith standard container interfacesempty()can be more efficient thansize() == 0for some container typesChanges
src/common/monitor/Sample.h: Addedbool empty() constmethod toTagSetclasssrc/common/monitor/ScopedMetricsWriter.h: Replaced 3 instances of.size() > 0with!.empty()Test plan
🤖 Generated with Claude Code