Add a granularity property to round to nearest 0.5C#220
Closed
emoses wants to merge 1 commit intodeiger:masterfrom
Closed
Add a granularity property to round to nearest 0.5C#220emoses wants to merge 1 commit intodeiger:masterfrom
emoses wants to merge 1 commit intodeiger:masterfrom
Conversation
emoses
commented
Mar 27, 2023
| typed_value = data_type[value] | ||
|
|
||
| # Update value precision for value to be sent to the A/C | ||
| precision = self._properties.get_precision(name) |
Author
There was a problem hiding this comment.
Since precision only makes sense if the property is an int anyway, I've moved this to the int clause above
emoses
commented
Mar 27, 2023
| # Round rather than fail if the input is a float. | ||
| # This is commonly the case for temperatures converted by HA from Celsius. | ||
| data_value = round(float(value)) | ||
| elif data_type is int: |
Author
There was a problem hiding this comment.
No reason to check for "." here, if it's an int value that doesn't have a decimal place the float logic won't affect it.
Author
|
Closed in favor of #222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using FGLair-us with HA. Even though my thermostats display in F, I have to set the
temp_typeto C to have anything function properly. It appears that the actual adjust_temperature commands that the wifi units accept must be in increments of 0.5 C, but when I change the temperature in F in HA, AirCon currenly rounds to the nearest degree C, which means many temperature adjustments are no-ops (e.g. 70F to 69F results in no change, they both round to 21C).Here's an example log:
To account for this, I've added a "granularity" property that will round to the nearest 0.5C before the precision is applied. This fixes the problem for me.