Fixed the NaN Calculation#4
Open
reef-hbloch wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
About 2-3 weeks ago, the CibusSplitter chrome extension started to malfunction resulting in "NaN" calculations of the amount each participant of the order is owed.
Remediation
After reviewing the code, it seems the issue was with the price extraction from the span, in which the code was looking for a
spantag with a class attribute value of__price__Wolt has published a new version that obscures the class names.
Work Around
If the participant is the host, the last
spantag is the price container, if he is not the host, the last one is the remove icon.therefore, we have to take the one before it.
Should resolve #3