Don't use get_lock in the default implementation.#5
Closed
Conversation
get_lock() changes behaviour in MySQL 5.7, which causes in turn causes workers to lock more rows than necessary. This patch changes the behavior of Data::Consumer::MySQL2 to claim rows by doing SELECT followed by UPDATE, instead of two SELECTs (second select was necessary to validate result of GET_LOCK() since it wasn't atomic, and was a major change from Data::Consumer::MySQL). SELECT followed by UPDATE allows two claim strategies to be implemented, both relying on implicit database locks: atomic CAS (used by default) and SELECT FOR UPDATE.
davydovmax
added a commit
to davydovmax/Data-Consumer
that referenced
this pull request
Sep 19, 2017
…nored
Without a fix, if we encounter this scenario, we will get an infinite loop in acquire():
1. start consuming
2. explicitly ignore() any item
3. continue consuming
4. wait till reset() is called (queue is exhausted or consume() called again)
4. try consume more items
5. acquire() receives already ignored item
6. item is ignored but $self->{last_id} is not updated
7. we skip item and loop back to demerphq#5, where process same item again
Fix just updates $self->{last_id} when we skip an ignored item. This
logic is similar to original logic in Data::Consumer::MySQL.
Owner
|
What do you think of https://github.com/demerphq/Data-Consumer/tree/remove-get-lock-2 It looks to me we need to take some defensive measures before we can merge this. See #7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
get_lock() changes behaviour in MySQL 5.7, which causes in turn causes
workers to lock more rows than necessary.
This patch changes the behavior of Data::Consumer::MySQL2 to claim rows
by doing SELECT followed by UPDATE, instead of two SELECTs (second
select was necessary to validate result of GET_LOCK() since it wasn't
atomic, and was a major change from Data::Consumer::MySQL).
SELECT followed by UPDATE allows two claim strategies to be implemented,
both relying on implicit database locks: atomic CAS (used by default)
and SELECT FOR UPDATE.