Conversation
…406) * fix: immediately purge caches on E173012 "too many modified relations" error When polling for modified relations returns E173012, the cache is now purged immediately instead of waiting for the cooldown window. This error is logged at WARN level (not ERROR) since it's an expected operational scenario, reducing unnecessary Datadog alert noise. Fixes: descope/etc#14411 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * chore(deps): update github.com/descope/common to latest main - Updated common from v0.0.9-0.20260224084244 to v0.0.9-0.20260308105939 - Go version bumped from 1.24.6 to 1.26.1 - Also updated related dependencies (grpc, protoc-gen-*, phonenumbers) * chore: dummy commit * chore: fix linter issue (copy solution from common repo) * chore: fix linter issue by building linter using go install --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: Omer Cohen <omercnet@users.noreply.github.com> (cherry picked from commit e259a25)
|
🐕 Review complete — View session on Shuni Portal 🐾 |
![shuni-bot-dev[bot]](https://avatars.githubusercontent.com/u/97479186?s=60&v=4){kind=small}
There was a problem hiding this comment.
🐕 Shuni's Review
Cherry-picked patch that adds immediate cache purge when the remote polling encounters an E173012 ("too many modified relations") error, bypassing the normal cooldown window.
No issues found — clean, focused fix with good test coverage (3 test cases covering the key scenarios). Good bones! 🦴
Contributor
Author
|
Deployed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e259a25)
Base commit: #392
Base deploy: https://descopeio.slack.com/archives/C04D389SWTT/p1772957296564369