Skip to content

fix(#163): fold comments into hunt Step 2 pr-list call#164

Merged
devallibus merged 1 commit into
masterfrom
issue/163-hunt-comments-in-list
Apr 22, 2026
Merged

fix(#163): fold comments into hunt Step 2 pr-list call#164
devallibus merged 1 commit into
masterfrom
issue/163-hunt-comments-in-list

Conversation

@devallibus
Copy link
Copy Markdown
Owner

Summary

Folds comments and commits into the Step 2 gh pr list call in commands/shiplog/hunt.md so signed-review evidence arrives in the first pr-list payload, not in a per-PR fallback. Turns the prior N+1 API pattern (one list + one gh pr view per PR) into a single list call, and re-scopes the per-PR gh pr view to truncation recovery only. Bumps plugin.json to 0.5.1 so downstream installs refresh.

Closes #163.

Journey Timeline

What prompted the fix

During a /shiplog:hunt run on devallibus/pogbeasts, PR #161 (which already carried three signed Reviewed-by: claude/opus-4.7 (claude-code) comments) was mis-classified as "no signed review." Investigation showed the installed commands/shiplog/hunt.md relied on the per-PR gh pr view call to discover comment-based signed reviews, and the runtime skipped that step after seeing a complete-looking list payload.

The post-#140 / post-#151 prompt text correctly instructs the model to scan comments in Step 2, but leaves the data fetch split into two calls. Because gh pr list supports comments as a JSON field, the split was unnecessary and failure-prone.

What changed

  • commands/shiplog/hunt.md Step 2: single gh pr list --state open --json number,title,isDraft,reviewDecision,reviews,body,url,headRefName,comments,commits --limit 20 call; per-PR gh pr view explicitly labeled as truncation fallback.
  • Acceptance checklist item 1 reworded to match the new default path plus fallback.
  • .claude-plugin/plugin.json version: 0.5.00.5.1.

Changes

  • ef5503b fix(#163): fold comments into hunt Step 2 pr-list call

Testing / Verification

  • Manually verified gh pr list --state open --json ...,comments,commits --limit 5 against devallibus/pogbeasts returns every open PR's comment bodies in one call, including the three signed Reviewed-by: artifacts on PR [shiplog/discovery] #156: de-hardcode master in CONTRIBUTING and CI workflows #161.
  • Version bump matches CONTRIBUTING.md gating rule; version-bump-check.yml will pass on this PR.
  • No tests or scripts reference the prior two-call shape; grep -R "gh pr view <N>" skills/ commands/ returns only the updated fallback line.

Knowledge For Future Reference

  • gh pr list --json accepts comments and commits — future commands should prefer one list call over a list + per-PR view fan-out when the field list supports it.
  • The versioning policy from [shiplog/plan] Plugin distribution: bump plugin.json version on content changes and start cutting releases #156 now has real teeth: any change under commands/, skills/, or .claude-plugin/ must bump plugin.json or CI fails. Bumping as part of the same PR is the cheap path.
  • Review gate note: the user explicitly authorized bypassing the cross-model review gate for this PR so the 0.5.1 release can ship immediately. Future PRs to shiplog should resume the standard cross-model review before merge.

Authored-by: claude/opus-4.7 (claude-code)
Last-code-by: claude/opus-4.7 (claude-code)
Captain's log — PR timeline by shiplog

Hunt Step 2 previously required N+1 API calls: one `gh pr list` plus one
`gh pr view <N> --json comments,commits` per open PR to locate signed
`Reviewed-by:` / `Disposition:` artifacts. Any agent that trusted the
first call and skipped the per-PR fallback classified PRs with valid
signed approvals as "no signed review" — the exact #140 failure mode
resurfacing on a different axis.

`gh pr list` supports `comments` and `commits` as JSON fields, so one
call can carry every open PR's top-level comment thread. Step 2 now
fetches both in a single call and documents the per-PR `gh pr view`
fallback as truncation recovery rather than the default path. Acceptance
checklist updated to match.

Bump plugin.json to 0.5.1 so downstream installs refresh per the
versioning policy.

Addresses #163 (completes T1, T2)

Co-Authored-By: claude/opus-4.7 (claude-code) <noreply@anthropic.com>
@devallibus devallibus added shiplog/history Final history-bearing Shiplog PR shiplog/issue-driven PR is linked to a Shiplog issue labels Apr 22, 2026
@devallibus devallibus merged commit 6d30468 into master Apr 22, 2026
1 check passed
@devallibus devallibus deleted the issue/163-hunt-comments-in-list branch April 22, 2026 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

shiplog/history Final history-bearing Shiplog PR shiplog/issue-driven PR is linked to a Shiplog issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[shiplog/plan] Include comments in hunt Context pre-fetch

1 participant