Skip to content

add LDFLAGS to Makefile#31

Merged
justwheel merged 1 commit intodevshane:masterfrom
Jan200101:PR/ldflags
Apr 20, 2026
Merged

add LDFLAGS to Makefile#31
justwheel merged 1 commit intodevshane:masterfrom
Jan200101:PR/ldflags

Conversation

@Jan200101
Copy link
Copy Markdown
Collaborator

tested with:
make LDFLAGS="-Wl,--build-id=md5"

@justwheel
Copy link
Copy Markdown
Collaborator

Seems related to some patches that @jamesjer opened against the downstream Fedora package.

@justwheel justwheel added the bug Something is broken or produces incorrect behavior label Feb 22, 2026
@justwheel justwheel added this to the v1.1.0 milestone Feb 22, 2026
@justwheel
Copy link
Copy Markdown
Collaborator

@jamesjer Would you be up for doing a peer review on this PR?

tested with:
`make LDFLAGS="-Wl,--build-id=md5"`
@justwheel
Copy link
Copy Markdown
Collaborator

I rebased the PR on the latest changes in master branch after #30 merged. I am keeping this PR open a bit longer to invite any final review here. @jamesjer, did you still want to help out with the code review?

@justwheel
Copy link
Copy Markdown
Collaborator

I want to merge #38 ahead of this PR. Then, after merging, this PR can be rebased on master and we can more deterministically use the CI pipeline to assess future Pull Requests to ensure that both GCC and Clang successfully compile Zork.

@justwheel
Copy link
Copy Markdown
Collaborator

I take it back – this change appears really simple. Enough time has passed for feedback, so I am going to merge this to master, and alternatively, I will rebase #38 with this commit once it lands.

Merging! 🌊

@justwheel justwheel merged commit 05e4dd6 into devshane:master Apr 20, 2026
@justwheel justwheel added build system Makefile, compiler flags, linker settings, install targets and removed bug Something is broken or produces incorrect behavior labels Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build system Makefile, compiler flags, linker settings, install targets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create git tag/release for Zork v1.1.0

3 participants