fix: remove app list filter empty state on clear search#3080
Merged
Conversation
|
Some linked issues are invalid. Please update the issue links:\nIssue # in is not found or invalid (HTTP }404).\n |
vivek-devtron
approved these changes
Mar 24, 2026
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the Devtron app list empty-state behavior by moving the “Create your first application” guided cards rendering behind the Table’s ViewWrapper, so the guided cards are shown only when there are no rows and no search/filters are applied.
Changes:
- Added a
ViewWrapperinDevtronAppListContainerto render guided cards whennoRows && !isSearchOrFilterApplied. - Updated
TableAdditionalPropsTypeto includenoRowsandisSearchOrFilterAppliedand passed them viaadditionalProps. - Wired
ViewWrapperinto theTablevia theViewWrapperprop and importedTableViewWrapperProps.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/components/app/list/types.tsx |
Extends TableAdditionalPropsType to include noRows and isSearchOrFilterApplied for wrapper logic/type-safety. |
src/components/app/list/DevtronAppListContainer.tsx |
Introduces ViewWrapper + guided cards rendering and passes required props into Table’s additionalProps. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
arunjaindev
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This pull request refactors how the "Create your first application" guided cards are rendered in the
DevtronAppListContainercomponent. The main change is to move the guided cards logic into a newViewWrappercomponent, which is then passed to theTablecomponent for more modular and maintainable code. Additionally, theTableAdditionalPropsTypeinterface is updated to includenoRowsandisSearchOrFilterAppliedprops, ensuring correct prop passing and type safety.Component Refactoring and UI Behavior:
ViewWrappercomponent inDevtronAppListContainer.tsxthat renders the guided cards when there are no rows and no filters/search applied, improving code modularity and separation of concerns. ([src/components/app/list/DevtronAppListContainer.tsxR77-R119](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-5c086a7526148fa67d8f4c2a587a1fdc083a991b2a3ac52a2bc75d01617ec1afR77-R119))renderGuidedCardsfunction fromDevtronAppListand refactored its logic into the newViewWrapper. The guided cards are now rendered viaViewWrapperinstead of directly in the main render function. ([[1]](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-5c086a7526148fa67d8f4c2a587a1fdc083a991b2a3ac52a2bc75d01617ec1afL109-L138),[[2]](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-5c086a7526148fa67d8f4c2a587a1fdc083a991b2a3ac52a2bc75d01617ec1afL194-L197),[[3]](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-5c086a7526148fa67d8f4c2a587a1fdc083a991b2a3ac52a2bc75d01617ec1afR240))Type and Prop Updates:
TableAdditionalPropsTypeinterface intypes.tsxto includenoRowsandisSearchOrFilterAppliedproperties, ensuring these props are available for the new wrapper logic. ([src/components/app/list/types.tsxL107-R110](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-15d87e95aa4404cf61de423b940d066121ad3e9ce8b2eee1c1da90268183d4c3L107-R110))noRowsandisSearchOrFilterAppliedas part ofadditionalPropsto theTablecomponent, supporting the new wrapper behavior. ([src/components/app/list/DevtronAppListContainer.tsxR221-R222](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-5c086a7526148fa67d8f4c2a587a1fdc083a991b2a3ac52a2bc75d01617ec1afR221-R222))Dependency Updates:
TableViewWrapperPropsto the imports from@devtron-labs/devtron-fe-common-libto support the newViewWrappercomponent. ([src/components/app/list/DevtronAppListContainer.tsxR30](https://github.com/devtron-labs/dashboard/pull/3080/files#diff-5c086a7526148fa67d8f4c2a587a1fdc083a991b2a3ac52a2bc75d01617ec1afR30))Fixes https://github.com/devtron-labs/sprint-tasks/issues/2857
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: