Implement shields (complete vanilla)#1248
Draft
HashimTheArab wants to merge 16 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex ran for 4 hours off 1 prompt to build this (draft PR). More than half of this is tests, the code needs to be cleaned up a bit and remove redundant tests
Overview
Implements vanilla shield gameplay end-to-end: registers a new minecraft:shield item (offhand, durability/repair) and adds player-side shield blocking state driven by auth input and item-use, including warm-up delay, facing checks, durability loss, axe disable cooldown, recoil, and shield-block sound/metadata.
Extends combat interactions so shields can block melee/projectile/explosion damage and deflect projectiles (skipping hit effects/callbacks on deflection), while explosions now carry origin/source and a shield-blockability flag.
Updates TNT/explosion plumbing to preserve chain attribution and shield-blockability across primed TNT spawns (new optional EntityRegistryConfig.TNTWithSource, TNT entity behaviour/NBT support, and block TNT ignition/explosion source handling), plus ensures held/offhand inventory mutations refresh derived held-item/shield state via session transaction handlers.