Skip to content

feat(server/world): Implement armor visiblity to per-viewer view layers#1259

Open
cqdetdev wants to merge 2 commits into
df-mc:masterfrom
cqdetdev:codex/view-layer-armour
Open

feat(server/world): Implement armor visiblity to per-viewer view layers#1259
cqdetdev wants to merge 2 commits into
df-mc:masterfrom
cqdetdev:codex/view-layer-armour

Conversation

@cqdetdev

Copy link
Copy Markdown
Collaborator

A caveat to b9a408a is that armor is not hidden when a player goes out of a view. This means that a player could still be visible if they are wearing armor which may be an unintended side effect.

This PR implements the ability to manually choose to display armor as visible.

@RestartFU

Copy link
Copy Markdown
Collaborator

I think we should also be able to view specific armour, not just be either hidden or visible

@cqdetdev

Copy link
Copy Markdown
Collaborator Author

Good idea, i'm just not sure the use case for individual pieces but I can add it. Just need to make it clean

@RestartFU

Copy link
Copy Markdown
Collaborator

Good idea, i'm just not sure the use case for individual pieces but I can add it. Just need to make it clean

well I don't think it should be based on visibility, I think we should be able to set specific armour pieces, and if we want no armour, we can just have 4 empty stacks (or an empty inventory)

@cqdetdev

Copy link
Copy Markdown
Collaborator Author

That's what I meant. What I mean is like if a user wants a player invisible in the first place 99% of the time they'd want their armor invisible too and not probably only enable helmet but I guess you implemented that in one of your things so IG there is a usecase

@cqdetdev

Copy link
Copy Markdown
Collaborator Author

@RestartFU Have a look

@cqdetdev cqdetdev requested a review from HashimTheArab May 20, 2026 14:57
@RestartFU

Copy link
Copy Markdown
Collaborator

I like that better, I'll take a deeper look tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants