feat: awaitCallWithRounds method on PocketIcClient
#220
+10
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @m-styp, In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA. If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged. — The DFINITY Foundation |
ilbertt
suggested changes
Dec 19, 2025
ilbertt
changed the title
awaitCallWithRounds method on PocketIcClient
Co-authored-by: Luca Bertelli <[email protected]>
ilbertt
previously approved these changes
Dec 20, 2025
github-actions
bot
dismissed
ilbertt’s stale review
Review dismissed by automation script.
raymondk
approved these changes
Jan 5, 2026
Member
|
@raymondk I was commenting while you reopened the PR and before you merged it. Feels like it's worth considering but, just my two cents too. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
# Motivation PR #220 introduced a new `rounds` option for `awaitCall` by duplicating the existing function with a new function called `awaitCallWithRounds`. I randomly noticed the PR and discussed it with @raymondk, as it felt like neither an idiomatic solution nor particularly ergonomic, since it could have been resolved by simply adding the new optional parameter as... an optional parameter. Which is what this PR does. # Changes - Revert function `awaitCallWithRounds` (not a breaking change, as this was not yet shipped) - Add `rounds` to `AwaitCanisterCallRequest` parameter # Notes No tests, as none were provided in the original PR. No documentation, as none was provided in the original PR and none exists in the codebase for the related module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new function to use for specified number of Rounds on AwaitCall > awaitCallWithSpecifiedRounds
as discussed with @ilbertt - no breaking changes.