Skip to content

feat: Replace unprintable characters with control pictures - #282

Open
adamspofford wants to merge 3 commits into
masterfrom
spofford/controlpictures
Open

adamspofford wants to merge 3 commits into
masterfrom
spofford/controlpictures

Conversation

@adamspofford

Copy link
Copy Markdown
Contributor

Replaces unprintable ASCII characters with their equivalents from the Unicode 'Control Pictures' block.

@adamspofford
adamspofford requested a review from a team as a code owner September 18, 2026 16:03
@zeropath-ai

zeropath-ai Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

✅ No security or compliance issues detected. Reviewed everything up to b37a08c.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► src/lib/format/mod.rs
    Introduce TerminalSafe escaper and escape function; add depicted control-picture logic
Enhancement ► src/lib/format/templates/ckbtc/retrieve_btc_err.txt
    Use indentf(4) for error message formatting
Enhancement ► src/lib/format/templates/ckbtc/update_balance_err.txt
    Use indentf(4) for error message formatting
Enhancement ► src/lib/format/templates/ledger/icrc1_transfer_err.txt
    Use indentf(4) for error message formatting
Enhancement ► src/lib/format/templates/nns/full_neuron_info.txt
    Apply flat filter and indentf(4) to certain fields
Enhancement ► src/lib/format/templates/nns/manage_neuron.txt
    Apply indentf(4) to error messages
Enhancement ► src/lib/format/templates/nns/min_neuron_info.txt
    Apply flat and indentf(4) to fields
Enhancement ► src/lib/format/templates/nns/proposal_info.txt
    Apply flat and indentf(4) to title/summary/url and other fields; indent proposal action/description/metadata
Enhancement ► src/lib/format/templates/sns/manage_neuron.txt
    Apply indentf(4) to error message
Enhancement ► src/lib/format/tests.rs
    Add extensive tests for control code depiction, flat/indent behavior, and per-field indentation rules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants