[#1094][FIX] alerts: skip owner override when alert_owner_id is in updates#1100
Open
Romil2112 wants to merge 1 commit into
Open
[#1094][FIX] alerts: skip owner override when alert_owner_id is in updates#1100Romil2112 wants to merge 1 commit into
Romil2112 wants to merge 1 commit into
Conversation
… is in updates When batch-updating an alert with no owner, the route unconditionally set alert_owner_id to the current user, ignoring the value in the client payload. Guard the fallback so it only fires when the caller did not explicitly supply an owner.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1094.
When
alerts_batch_update_routeprocesses an alert withalert_owner_id = NULL, it unconditionally falls back tocurrent_user.id, ignoring anyalert_owner_idthe caller explicitly included in the payload. This causes the first Assign → [user] action on an ownerless alert to behave identically to Assign to me, requiring a second identical request to apply the intended owner.The fix adds a guard so the fallback only fires when the caller did not supply an
alert_owner_id:Test plan
alert_owner_idin the payload (e.g. a status-only update); verify it still falls back to the current user