fix: avoid division by zero when logging watch load rate - #4289
Open
snowyukitty wants to merge 1 commit into
Open
fix: avoid division by zero when logging watch load rate#4289snowyukitty wants to merge 1 commit into
snowyukitty wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
time.perf_counter().Root cause
load_all_watches()usedtime.time()and unconditionally formattedloaded / elapsedin both completion log paths. A fast load can receive identical clock readings, makingelapsed == 0.0; an empty datastore then aborts startup withZeroDivisionErrorwhile trying to log0 / 0.0.This was reproduced on Windows, where the wall clock has lower resolution, but the guard is platform-independent. The regression test replaces only this module's clock reference with constant readings, fails on
master, and passes with this fix.Testing
ZeroDivisionErroratfile_saving_datastore.py:330.pytest -q changedetectionio/tests/unit/test_file_saving_datastore.py— 1 passed.pytest -q changedetectionio/tests/unit/— 210 passed, 30 subtests passed.ruff check . --select E9,F63,F7,F82,INT.ruff check changedetectionio/tests/unit/test_file_saving_datastore.py.git diff --check.