Skip to content

fix: patch js-temporal 0.4.3 for Ethiopic calendar#545

Open
kabaros wants to merge 3 commits intomasterfrom
path-temporal
Open

fix: patch js-temporal 0.4.3 for Ethiopic calendar#545
kabaros wants to merge 3 commits intomasterfrom
path-temporal

Conversation

@kabaros
Copy link
Copy Markdown
Collaborator

@kabaros kabaros commented Apr 8, 2026

This is a temporary fix for https://dhis2.atlassian.net/browse/LIBS-830

The patch itself just adds the new era codes for Ethiopic calendar (it looks bigger because we have to patch the minified ES/ CJS output of the library)

The longer-term fix is updating to the latest 0.5 polyfill version, but that:

  1. still has the bug with the Ethiopic calendar eras (but should be fixed in the next release: fix: add updated era codes to EthiopicHelper js-temporal/temporal-polyfill#357)
  2. This will likely be a breaking change for our UI library and few of the apps that use multi-calendar-dates directly (especially the ones that use Nepali dates directly)

@kabaros kabaros marked this pull request as draft April 8, 2026 07:14
@dhis2-bot
Copy link
Copy Markdown
Contributor

dhis2-bot commented Apr 8, 2026

🚀 Deployed on https://pr-545--dhis2-data-entry.netlify.app

@dhis2-bot dhis2-bot temporarily deployed to netlify April 8, 2026 07:17 Inactive
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

@dhis2-bot dhis2-bot temporarily deployed to netlify April 8, 2026 07:26 Inactive
@kabaros kabaros marked this pull request as ready for review April 8, 2026 07:36
@kabaros kabaros requested review from KaiVandivier and tomzemp April 8, 2026 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants