chore: [ANDROSDK-2183] Review online order clause in event query #2497
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcamsn
force-pushed
the
ANDROSDK-2183
branch
from
2b61103 to
6f2785f
Compare
taridepaco
force-pushed
the
ANDROSDK-2183
branch
from
6f2785f to
2b61103
Compare
vgarciabnz
reviewed
Nov 26, 2025
| criteria.ouMode()?.let { builder.orgUnitMode(it) } | ||
| criteria.assignedUserMode()?.let { builder.assignedUserMode(it) } | ||
| criteria.order()?.let { builder.order(parseOrderString(it)) } | ||
| criteria.order()?.let { builder.order(parseOrderString(it, TrackerExporterVersion.V1)) } |
Member
There was a problem hiding this comment.
Isn't it hardcoded here that the version is always V1?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Column names for sorting in online queries were not being transforemed into the correct ones from the new tracker endpoint, as it was done for tei queries. Now that event queries are enabled, the mapping needed to be added as well.
Related task ANDROSDK-2183