Simplified ParseMonsterId() by using the magic_enum library #8090
Conversation
|
Will you be able to fix this for other builds? Since most fail from it we can't really merge it as is. |
I think yes, but I'll need some time, since I need to figure out what is wrong, and I don't have any leads at the moment. I think during next week I'll be able to fix this. |
|
A dependency on magic enum needs to be added to the libdevilutionx CMake target |
Andrettin
force-pushed
the
master
branch
3 times, most recently
from
f9600c6 to
5449984
Compare
Yup, that was it :) Thank you so much! |
|
|
||
| tl::expected<_monster_id, std::string> ParseMonsterId(std::string_view value) | ||
| { | ||
| if (value == "MT_NZOMBIE") return MT_NZOMBIE; |
There was a problem hiding this comment.
What happens once this is renamed to MonsterType::Zombie? Ideal it should produce Zombie
There was a problem hiding this comment.
Yes, that's exactly what it would produce :)
There was a problem hiding this comment.
In that case could you resolve the merge conflict, after that i think it's ready to merge.
There was a problem hiding this comment.
I fixed the merge conflicts now :)
3 participants
This pull request adds the (header-only) magic_enum library as a dependency, and uses it to simplify ParseMonsterId(). The library could be used in the future to simplify other similar functions as well.