Skip to content

Conversation

@Andrettin
Copy link
Contributor

With the implementation of the floating infobox option, now item properties (e.g. durability, magic affix effects) do not appear in the normal infobox, even if the floating infobox option is disabled. This PR fixes this.

@AJenbo
Copy link
Member

AJenbo commented Aug 12, 2025

Thanks, I didn't realize it would redirect the info. I guess we should refactor things a bit and have different methods for this like AddItemInfo() where in can then send it to either the floating box (if enabled) or the general info box.

Then we would also know how much is left to move somewhere else before we can rework the main panel.

@AJenbo AJenbo enabled auto-merge (rebase) August 12, 2025 11:29
@AJenbo AJenbo merged commit 0e005c8 into diasurgical:master Aug 12, 2025
24 checks passed
@Andrettin
Copy link
Contributor Author

Thanks, I didn't realize it would redirect the info. I guess we should refactor things a bit and have different methods for this like AddItemInfo() where in can then send it to either the floating box (if enabled) or the general info box.

Then we would also know how much is left to move somewhere else before we can rework the main panel.

I agree, it would be good to refactor this to simplify the code. I'll work on that (for the cases fixed here), and create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants