chore: update tend workflows (0.1.12 → 0.1.16) - #340
Conversation
Deploying mouseterm with
|
| Latest commit: |
d844e6e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e2bfa83.mouseterm.pages.dev |
| Branch Preview URL: | https://tend-update-workflows.mouseterm.pages.dev |
dormouse-bot
left a comment
There was a problem hiding this comment.
Reviewing my own PR — this is a clean regeneration (version bump 0.1.12 → 0.1.13 across all eight files, plus the tend-mention relay/dispatch rework and the environment: tend job gating from the linked upstream changes), so no code-level concerns. One operational note the maintainer should see, since it isn't visible in the diff:
The tend environment doesn't exist yet, and the two operational secrets are still repo-level. This repo currently has only the security-audit and vscode-extension-publish environments, and TEND_BOT_TOKEN / CLAUDE_CODE_OAUTH_TOKEN are repo-level secrets. So:
- Merging won't break CI. Repository-level secrets stay accessible to jobs that reference an environment, and GitHub auto-provisions the referenced
tendenvironment (with no protection rules) on first run. The workflows keep working exactly as before. - But the #810 hardening is inert until you finish the setup. The point of
environment: tendis to gate the deploy secrets behind a deployment environment. With the secrets still at repo level and the environment unprotected, theenvironment: tendlines currently add no isolation — any workflow can still reach the tokens. To realize the benefit, moveTEND_BOT_TOKENandCLAUDE_CODE_OAUTH_TOKENinto thetendenvironment and add a deployment-branch protection rule. - Caution on how you gate it: use a deployment-branch/tag rule, not a "Required reviewers" rule. Required reviewers pause every job that targets the environment until a human approves the deployment — and the bot can't approve its own, so it would stall every scheduled
nightly/weekly/review/triagerun behind a manual gate.
Flagging for @nedtwigg to decide — the follow-up is a repo-settings change (environment + secret move), not a code edit, and these files are generated so it can't live in the PR.
Automated nightly regeneration of tend's workflow files, refreshed onto the latest release.
tend version: 0.1.12 → 0.1.16
Notable changes (consumer-relevant):
tend checknow sweeps every credential-holding environment (not just secret-holding ones) and refuses a job that both names the environment and files a deployment (Move operational secrets into a gated deployment environment max-sixty/tend#810, check: sweep credential-holding environments, not just secret-holding ones max-sixty/tend#815, check: refuse a job that names the environment and files a deployment max-sixty/tend#853, fix(check): stop pointing credential-environments at the setting it rejects max-sixty/tend#900). Directly relevant to the openenvironment/credential-environmentsdrift on this repo (tend check: configuration drift on diffplug/dormouse #339)./code-reviewis now a tend-owned review skill, its second pass is unconditional, and review pushes queue behind an examined-HEAD gate instead of cancelling the reviewer (fix(review): port /code-review into a tend-owned skill max-sixty/tend#819, feat(review): queue pushes behind an examined-HEAD gate instead of cancelling max-sixty/tend#903, fix(review): make the code-review second pass unconditional max-sixty/tend#937, fix(review): re-review after a force-push instead of trusting the re-anchored review SHA max-sixty/tend#884).rerun --failedpoll now have terminal caps that print conclusions, and a review landing mid-poll is left to tend-mention (fix(running-in-ci): make the CI-monitor poll cap terminal max-sixty/tend#876, fix(running-in-ci): make the rerun poll cap terminal, and print conclusions max-sixty/tend#951, fix(running-in-ci): leave a review that lands mid-poll to tend-mention max-sixty/tend#870).Full diff: max-sixty/tend@0.1.12...0.1.16