Skip to content

Conversation

@cid-chan
Copy link

This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".

@BigBlueHat
Copy link
Contributor

This looks fine generally, but lets get some tests written for it. @anatoly-scherbakov would you be up for doing that to test out the "local tests" you were sad we didn't have here?

@BigBlueHat BigBlueHat added this to the v2.0.4 milestone Feb 5, 2024
@BigBlueHat BigBlueHat modified the milestones: v2.0.4, v2.0.5 Feb 12, 2024
@mielvds
Copy link
Collaborator

mielvds commented Jan 5, 2026

@anatoly-scherbakov if it still makes sense; could you pick this back up? #228 introduces some "local tests" you can extend.

This fixes a bug with activitypub related documents: The schema "https://www.w3.org/ns/activitystreams" renders the spec if "application/json" has a lower prioritisation than "text/html".
Copy link
Collaborator

@mielvds mielvds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The only thought I had was about the use of class-based vs function-based tests. OK for merging as is, but I might merge this with another test file in #228 later on.

@mielvds mielvds added bug and removed needs tests labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants