App Ingress authority routing only supports exact matching #937#994
Merged
sjana-do merged 5 commits intodigitalocean:mainfrom May 4, 2026
Conversation
Contributor
There was a problem hiding this comment.
Update to apps_accessors_test.go is missing.
greeshmapill
approved these changes
Apr 17, 2026
harshmaru7
reviewed
Apr 20, 2026
Contributor
harshmaru7
left a comment
harshmaru7
left a comment
There was a problem hiding this comment.
This fixes the bug but it looks like a breaking change
Contributor
Author
not every customer but who directly import "github.com/digitalocean/godo" in their own code and upgrade to the new version, they will have to change update thier code base accordingly and it will be a compile error for them |
sjana-do
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - #937
Root Cause
The bug is in
https://github.com/aupadhyay-shark/godo/blob/e9ef74c396061df3c575c27b8d5f44c789424139/apps.gen.go
type AppIngressSpecRuleStringMatch struct {
Prefix string json:"prefix,omitempty"
Exact string json:"exact,omitempty"
}
Fix
Changed Prefix and Exact from string to *string in AppIngressSpecRuleStringMatch