This repository was archived by the owner on Jun 17, 2026. It is now read-only.
Expose prom_collector_default_collect function#75
Open
dsmeytis wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I faced the problem when tried to write a custom collector for my project.
The type definition for the collector is
typedef prom_map_t *prom_collect_fn(prom_collector_t *self);However
prom_collector_tis an opaque type and evenmetricsfield can't be accessed outside library to be returned by the custom collector.I added a definition of the existing
prom_collector_default_collectfunction that just returnsmetricsmember of the collector.