Skip to content

Docker Restoration and Fixes#1431

Open
jeff-hykin wants to merge 89 commits intodevfrom
jeff/fix/docker3
Open

Docker Restoration and Fixes#1431
jeff-hykin wants to merge 89 commits intodevfrom
jeff/fix/docker3

Conversation

@jeff-hykin
Copy link
Member

@jeff-hykin jeff-hykin commented Mar 6, 2026 •
edited
Loading

Problem(s)

  • This is a blocker for G1 rosnav stack parity with Go2, ref DIM-569
  • DockerModules stopped working on dev
  • configure_stream does not support different transport types (Blocker for DIM-569)
  • A failed DockerModule build wouldn't stop the container (leak)
  • A new container name was generated every run (huge build up of containers)
  • We have no tests for docker (how it got broken on dev in the first place)
  • No way to pull an image (rather than local dockerfile)
  • No way to change build args (ex: can't add network flag)
  • Image never rebuilds even if dockerfile edited or build args changes
  • DockerModules didn't deploy in parallel
  • There was a bug with error handling of WorkerManager

Closes DIM-662

Solution

  • Add tests
  • Minimal change to ModuleCoordinator to restore functionality: deploy docker modules in parallel
  • remove configure_stream (not needed) in favor of using set_transport work as intended to allow different stream types
  • stop/cleanup fixes

Breaking Changes

None

How to Test

python ./examples/docker_hello_world/hello_docker.py

Contributor License Agreement

  • I have read and approved the CLA.

spomichter and others added 30 commits January 23, 2026 07:34
@spomichter
Merge pull request #1056 from dimensionalOS/dev - Pre-Release v0.0.8:…
3b46344 
… Unitree Go2 Navigation & Exploration Beta

Pre-Release v0.0.8: Unitree Go2 Navigation & Exploration Beta, Transport Updates, Documentation updates, Rerun fixes, Person follow, Readme updates

## What's Changed
* Small docs clarification about stream getters by @leshy in #1043
* Fix split view on wide monitors by @jeff-hykin in #1048
* Docs: Install & Develop  by @jeff-hykin in #1022
* Add uv to nix and fix resulting problems by @jeff-hykin in #1021
* v0.0.8 by @paul-nechifor in #1050
* Style changes in docs by @paul-nechifor in #1051
* Revert "Add uv to nix and fix resulting problems" by @leshy in #1053
* Transport benchmarks + Raw ros transport by @leshy in #1038
* feat: default to rerun-web and auto-open browser on startup (browser … by @Nabla7 in #1019
* bbox detections visual check by @leshy in #1017
* fix: only auto-open browser for rerun-web viewer backend by @Nabla7 in #1066
* move slow tests to integration by @paul-nechifor in #1063
* Streamline transport start/stop methods by @Kaweees in #1062
* Person follow skill with EdgeTAM by @paul-nechifor in #1042
* fix: increase costmap floor z_offset to avoid z-fighting by @Nabla7 in #1073
* Fixed issue #1074 by @alexlin2 in #1075
* ROS transports initial by @leshy in #1057
* Fix System Config Values for LCM on MacOS and Refactor by @jeff-hykin in #1065
* SHM Transport basic fixes by @leshy in #1041
* commented out Mem Transport test case by @leshy in #1077
* Docs/advanced streams update 2 by @leshy in #1078
* Fix more tests by @paul-nechifor in #1071
* feat: navigation docker updates from bona_local_dev by @baishibona in #1081
* Fix missing dependencies by @Kaweees in #1085
* Release readme fixes by @spomichter in #1076

## New Contributors
* @baishibona made their first contribution in #1081

**Full Changelog**: v0.0.7...v0.0.8
@spomichter
Merge pull request #1092 - v0.0.9 Release Patch: Git clone change to …
e4defcb 
…HTTPS from SSH, get_data change, LFS changes

v0.0.9 Release Patch: Git clone change to HTTPS from SSH, get_data change, LFS changes
@spomichter
Merge pull request #1336 from dimensionalOS/dev
8e0f31a 
Release v0.0.10: Manipulation Stack, MuJoCo Simulation, DDS Transport, Web and Native Visualization via Rerun


## Highlights

88+ commits, 20 contributors, 700+ files changed.

The TLDR: **a complete manipulation stack**, **MuJoCo simulation**, **DDS transport**, and **a rewritten visualization pipeline**. Agents are no longer bolted on top — they're refactored as native modules with direct stream access. The entire ROS message dependency has been removed from core DimOS, and we've added VR, phone, and arm teleoperation stacks. You can now vibecode a pick-and-place task from natural language to motor commands. Installation has been significantly streamlined — no more direnv, simpler setup, and the web viewer is now the default.

---

## 🚀 New Features

### Simulation
- **MuJoCo simulation module** — Run any DimOS blueprint in simulation with no hardware. Supports xArm and Unitree embodiments, parses MJCF/URDF for robot properties, monotonic clock timing (no `time.sleep`). `dimos --simulation run unitree-go2` ([#1035](#1035)) by @jca0
- **Simulation teleop blueprints** — Added simulation teleop blueprints for Piper, xArm6, and xArm7. ([#1308](#1308)) by @mustafab0

### Manipulation
- **Modular manipulation stack** — Full planning stack with Drake: FK/IK solvers (Jacobian + Drake optimization), RRT path planning, world model with obstacle monitoring, multi-robot management. xArm6/7 and Piper support. ([#1079](#1079)) by @mustafab0
- **Joint servo and cartesian controllers** — Joint position/velocity controllers and cartesian IK task with Pinocchio solver. PoseStamped stream input for real-time control. ([#1116](#1116)) by @mustafab0
- **GraspGen integration** — Grasp generation via Docker-hosted GPU model. Lazy container startup, thread-safe init, RPC `generate_grasps()` returns ranked PoseArray. ([#1119](#1119), [#1234](#1234)) by @JalajShuklaSS
- **Gripper control** — Gripper RPC methods on control coordinator, exposed adapter property for custom implementations. ([#1213](#1213)) by @mustafab0
- **Detection3D and Object support** — Object input topics, TF support on manipulation module, pointcloud-to-convex-hull for Drake imports. ([#1236](#1236)) by @mustafab0
- **Agentic pick and place** — Reimplemented manipulation skills for agent-driven pick-and-place workflows. ([#1237](#1237)) by @mustafab0

### Teleoperation
- **Quest VR teleoperation** — Full WebXR + Deno bridge stack. Quest controller data (pose, trigger, grip) streamed to DimOS modules. Monitor-style locking for control loops. ([#1215](#1215)) by @ruthwikdasyam
- **Phone teleoperation** — Control Go2 from your phone with a web-based teleop interface. ([#1280](#1280)) by @ruthwikdasyam
- **Arm teleop with Pinocchio IK** — Single and dual arm teleoperation using Pinocchio inverse kinematics. Blueprints for xArm, Piper, and dual configurations. ([#1246](#1246)) by @ruthwikdasyam

### Transports & Infrastructure
- **DDS transport protocol** — CycloneDDS transport with configurable QoS (high-throughput and reliable profiles). Optional install, benchmark integration. ([#1174](#1174)) by @Kaweees
- **Pubsub pattern subscriptions** — Glob and regex pattern matching for topic subscriptions. `subscribe_all()` for bridge-style consumers. Topic type encoding in channel strings (`/topic#module.ClassName`). ([#1114](#1114)) by @leshy
- **LCM raw bytes passthrough** — Skip `lcm_encode()` when message is already bytes. ([#1223](#1223)) by @leshy
- **Unified TimeSeriesStore** — Pluggable backends (InMemory, SQLite, Pickle, PostgreSQL) with SortedKeyList for O(log n) operations. Replaces the old replay system and TimestampedCollection. Collection API with slice, range, and streaming methods. ([#1080](#1080)) by @leshy
- **DimosROS benchmark tests** — Benchmark suite for ROS transport performance. ([#1087](#1087)) by @leshy

### Navigation
- **FASTLIO2 support** — Hardware-verified localization with arm64 support. Docker deployment with FAR Planner, terrain analysis, and bagfile playback mode. Builds or-tools from source on arm64. ([#1149](#1149)) by @baishibona
- **Native Livox + FASTLIO2 module** — First-class DimOS native module for Livox Mid-360 lidar with FASTLIO2 localization. ([#1235](#1235)) by @leshy

### Visualization
- **RerunBridge module and CLI** — New bridge that subscribes to all LCM messages and logs those with `to_rerun()` to Rerun viewer. GlobalConfig singleton, web viewer support. Replaces the old rerun initialization system. ([#1154](#1154)) by @leshy
- **Webcam rerun visualization** — Camera module logs to Rerun with pinhole projection for 3D visualization. ([#1117](#1117)) by @ruthwikdasyam
- **Default viewer switched to rerun-web** — Browser-based viewer is now the default for broader compatibility. No native viewer install needed. ([#1324](#1324)) by @spomichter

### Agents
- **Agent refactor** — Restructured agent module with cleaner imports and global config integration. ([#1211](#1211)) by @paul-nechifor
- **Timestamp knowledge** — Agents now have timestamp awareness in prompts for temporal reasoning. ([#1093](#1093)) by @ClaireBookworm
- **Observe skill** — Go2 can now observe (capture and describe) its environment via agent skill. ([#1109](#1109)) by @paul-nechifor

### Platform & Hardware
- **G1 without ROS** — Unitree G1 blueprints decoupled from ROS dependency. Lazy imports for fast startup. ([#1221](#1221)) by @jeff-hykin
- **ARM (aarch64) support** — DimOS runs on ARM hardware. Platform-conditional dependencies, open3d source builds for arm64. ([#1229](#1229)) by @jeff-hykin
- **Universal joint/hardware schema** — `HardwareComponent` dataclass with `JointState`, `JointName` type aliases. Backend registry with auto-discovery for SDK adapters. ([#1040](#1040), [#1067](#1067)) by @mustafab0

---

## 🔧 Improvements

- **Optional Dask** — Start without Dask using `--no-dask` flag. Startup time reduced from ~60s to ~45s. ([#1111](#1111), [#1232](#1232)) by @paul-nechifor
- **RPC rework** — Renamed `ModuleBlueprint` → `_BlueprintAtom`, `ModuleBlueprintSet` → `Blueprint`, `ModuleConnection` → `Stream`. Added `ModuleRef`, improved type hints throughout. ([#1143](#1143)) by @jeff-hykin
- **Image class simplification** — Rewritten as pure NumPy dataclass. Removed CUDA backend, unused methods (solve_pnp, csrt_tracker), and image_impls/ directory. ([#1161](#1161)) by @leshy
- **Odometry message cleanup** — Simplified Odometry message type. ([#1256](#1256)) by @leshy
- **Remove all ROS message dependencies** — Purged ROS message types from core DimOS. Refactored rosnav to use ROSTransport. Removed dead ROS bridge code. ([#1230](#1230)) by @alexlin2
- **Removed bad function serialization** — Eliminated unnecessary serialization of Python functions. ([#1121](#1121)) by @paul-nechifor
- **Benchmark IEC units** — Switched bandwidth benchmarks from SI to IEC units for accuracy. ([#1147](#1147)) by @leshy
- **Pubsub typing improvements** — Thread-safety locks on `subscribe_new_topics` and `subscribe_all`. Proper type params across pubsub stack. ([#1153](#1153)) by @leshy
- **Autogenerated blueprint list** — Blueprints are now auto-discovered and listed. ([#1100](#1100)) by @paul-nechifor
- **Generic Buttons message** — Renamed `QuestButtons` to `Buttons` with generic field names for cross-platform teleop. ([#1261](#1261)) by @ruthwikdasyam
- **Dev container uses ros-dev image** — `./bin/dev` now runs the ROS-enabled dev image. ([#1170](#1170)) by @leshy
- **LSP support** — Added python-lsp-server and python-lsp-ruff to dev dependencies. ([#1169](#1169)) by @leshy
- **Lazy-load pyrealsense2** — RealSense camera module uses lazy imports to avoid errors in simulation environments without the SDK. ([#1309](#1309)) by @spomichter
- **Removed unused mmcv and mmengine** — Dead Detic dependencies removed, eliminating slow source builds from install. ([#1319](#1319)) by @spomichter
- **Simplified installation** — Removed direnv requirement, streamlined install instructions across all platforms. ([#1315](#1315)) by @spomichter
- **DDS extra excluded from --all-extras** — `cyclonedds` requires a source build, so `dds` is now excluded from `uv sync --all-extras` by default. ([#1318](#1318)) by @spomichter
- **Nix pre-commit skip** — Skip pre-commit install if hooks already exist. ([#1162](#1162)) by @leshy
- **Removed base-requirements** — Consolidated dependency management. ([#1098](#1098)) by @paul-nechifor
- **Removed old graspnet** — Cleaned up deprecated graspnet version. ([#1248](#1248)) by @paul-nechifor
- **Code cleanup** — Removed `tofix` markers ([#1216](#1216)), fixed ruff issues ([#1112](#1112)), removed old README_installation.md ([#1101](#1101)) by @paul-nechifor

---

## 🐛 Bug Fixes

- Fix LFS updating (move from .local to venv) ([#1090](#1090)) by @jeff-hykin
- Launch hotfixes: git clone HTTPS, get_data main branch ([#1091](#1091)) by @spomichter
- Fix camera demo not showing in Rerun ([#1148](#1148)) by @jeff-hykin
- Default to rerun native viewer ([#1099](#1099)) by @Nabla7
- Fix exploration blocking agent loop ([#1258](#1258)) by @paul-nechifor
- Fix person-follow blocking agent loop ([#1278](#1278)) by @paul-nechifor
- Skip metric3d tests on unsupported xformers GPUs (Blackwell compute capability >9.0) ([#1225](#1225)) by @leshy
- Fix manipulation tests ([#1218](#1218), [#1247](#1247)) by @jeff-hykin, @paul-nechifor
- Fix control coordinator e2e test ([#1212](#1212)) by @mustafab0
- Fix xarm7-sim broken e2e tests ([#1294](#1294)) by @paul-nechifor
- Pin langchain to restore supported providers ([#1241](#1241)) by @spomichter
- Fix missing library dependencies in Nix flake ([#1240](#1240)) by @Kaweees
- Fix discord invite link ([#1122](#1122)) by @spomichter
- macOS edgecase fix ([#1096](#1096)) by @jeff-hykin
- Fix second N in logo ([#1250](#1250)) by @jeff-hykin
- Fix Unitree Go2 minor issues ([#1307](#1307)) by @paul-nechifor
- Fix broken tests ([#1305](#1305)) by @ruthwikdasyam
- Fix `uv sync` for some macOS systems ([#1322](#1322)) by @jeff-hykin
- Fix mmcv install ([#1313](#1313)) by @paul-nechifor
- Fix mypy issues ([#1150](#1150), [#1167](#1167), [#1257](#1257)) by @leshy, @paul-nechifor, @jeff-hykin
- Fix Nix install uv pip extras ([#1321](#1321)) by @spomichter

---

## 📚 Documentation

- **Major docs overhaul** — New README with feature grid, hardware table, quickstart. Navigation, transports, data streams, and agent docs. ([#1295](#1295)) by @leshy
- **Day 1 docs** — Comprehensive getting started guide, development docs, contributing guide, architecture overview. Executable blueprint docs via md-babel-py. ([#1064](#1064)) by @jeff-hykin
- **Arm integration guide** — How-to for integrating new robotic arms with DimOS. ([#1238](#1238)) by @mustafab0
- **MCP documentation update** — Updated MCP install and usage instructions. ([#1251](#1251)) by @Kaweees
- **Docker docs** — First pass on Docker deployment documentation. ([#1151](#1151)) by @leshy
- **Transports documentation** — Encode/decode mixins, SHM examples, ROS/DDS transport docs. ([#1107](#1107)) by @leshy
- **Rerun API examples** — Updated examples for the new RerunBridge API. ([#1262](#1262)) by @jeff-hykin
- **PR template** added ([#1172](#1172)) by @christiefhyang
- **Simplified install instructions** — Removed direnv, streamlined across all platforms. ([#1315](#1315)) by @spomichter
- **Python example restored** — Added back the Python usage example. ([#1317](#1317)) by @jeff-hykin
- **Nix install updated** — Replaced uv with pip for Nix compatibility. ([#1326](#1326)) by @ruthwikdasyam
- **README improvements** ([#1311](#1311)) by @paul-nechifor
- **Simplified writing docs** — Consolidated writing_docs to a single markdown file. ([#1254](#1254)) by @jeff-hykin

---

## 🏗️ CI & Build

- **ci-complete gate** — Dynamic branch protection via single aggregated status check. MD-only PRs no longer blocked. ([#1279](#1279)) by @spomichter
- **Path-based test filtering** — Test jobs fully skip (no container spin-up) when no relevant code changed. ([#1284](#1284), [#1286](#1286)) by @spomichter
- **Navigation docker build workflow** — CI builds for the ROS navigation stack. ([#1259](#1259)) by @spomichter
- **CUDA test marker** — `@pytest.mark.cuda` for GPU-dependent tests. ([#1220](#1220)) by @jeff-hykin
- **e2e test marker** — Marked end-to-end tests for selective CI runs. ([#1110](#1110)) by @paul-nechifor
- **pytest stdin fix** — Added `-s` to default addopts for LCM autoconf compatibility. ([#1320](#1320)) by @spomichter

---

## ⚠️ Breaking Changes

- **RPC renames**: `ModuleBlueprint` → `_BlueprintAtom`, `ModuleBlueprintSet` → `Blueprint`, `ModuleConnection` → `Stream` ([#1143](#1143))
- **Image class rewrite**: `CudaImage` and `NumpyImage` removed. Image is now a pure NumPy dataclass. Methods like `solve_pnp`, `csrt_tracker`, `from_depth`, `to_depth_meters` removed. ([#1161](#1161))
- **ROS messages removed from core**: All `to_ros`/`from_ros` conversion methods removed. Use `ROSTransport` instead. ([#1230](#1230))
- **QuestButtons → Buttons**: Renamed with generic field names. ([#1261](#1261))
- **RerunBridge replaces old rerun init**: `dimos.dashboard.rerun_init` removed. Use `RerunBridgeModule` or the `rerun-bridge` CLI. ([#1154](#1154))
- **Unitree directory restructuring**: `unitree_go2` → `unitree/go2`, `unitree_g1` → `unitree/g1`. Blueprint names updated. ([#1221](#1221))
- **Default viewer is now rerun-web**: Use `--viewer-backend rerun` to restore native viewer. ([#1324](#1324))

---

## Quickstart

```bash
# Install
uv pip install dimos[base,unitree]

# Try it (no hardware needed)
# NOTE: First run downloads ~2.4 GB from LFS
dimos --replay run unitree-go2

# Simulate
uv pip install dimos[base,unitree,sim]
dimos --simulation run unitree-go2
```

---

## New Contributors 🎉

- @ruthwikdasyam — Quest VR teleoperation, phone teleop, arm teleop, webcam rerun viz
- @JalajShuklaSS — GraspGen integration
- @jca0 — MuJoCo simulation module
- @christiefhyang — PR template

---

**Full Changelog**: [v0.0.9...v0.0.10](v0.0.9...v0.0.10)
@spomichter
Merge pull request #1340 from dimensionalOS/dev
593a7f3 
docs(go2): add getting started guide (#1339)
@jeff-hykin
add docker example
758fbc4
@jeff-hykin
add docker module system
4c9c27d
@jeff-hykin
fixup
a0e719d
@jeff-hykin
fix rerun imports
f559ff8
@jeff-hykin
fixup imports
13acbf5
@jeff-hykin
fixup
5ab56d5
@jeff-hykin
simplify stop logic
4fcd2bc
@jeff-hykin
simplify and explain
057a373
@jeff-hykin
parallel start of docker modules
0027258
@jeff-hykin
fix container name to be stable
f685fc0
@jeff-hykin
lazy import
c8276e1
@jeff-hykin
clean up
971d2f7
@jeff-hykin
Merge branch 'dev' of github.com:dimensionalOS/dimos into jeff/fix/do…
5f686c1 
…cker3
@jeff-hykin
Merge branch 'dev' into jeff/fix/docker3
0dd1dd1
@jeff-hykin
revert
868e356
@jeff-hykin
cleanup
bea6f7a
@jeff-hykin
fixup deploy_parallel
16b2007
@jeff-hykin
clean up reconnect logic
aa42ced
@jeff-hykin
fixup
6d07778
@jeff-hykin
-
d74173f
@jeff-hykin
fix deployment/coordinator timeline
d2aafee
@jeff-hykin
fir enforcement of either dockerfile or image pull
f6b4c57
@jeff-hykin
fix reconnect system
2c03652
@jeff-hykin
-
c225a9a
@jeff-hykin
fix deploy_parallel
4fd09b7
@jeff-hykin
better error
b514747
jeff-hykin and others added 5 commits March 13, 2026 15:09
@jeff-hykin @claude
fix: update Docker deployment to use ModuleSpec format
bf8b429 
- docker_worker_manager: accept ModuleSpec format, pass global_config
- module_coordinator: add type: ignore for ModuleBase→Module cast
- worker_manager: convert Iterable to list for len() check
- test_docker_deployment: fix Path import, update test assertions for
  new global_config signature

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeff-hykin @claude
chore: resolve conflicts with dev
56f7ddc 
Merged origin/dev, resolving import conflict in docker_runner.py:
- Updated LCMRPC import path to dimos.protocol.rpc.pubsubrpc (from dev)
- Kept ModuleProxyProtocol import and lazy docker_build imports (PR intent)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeff-hykin @claude
fix(mypy): cover import-not-found for onnxruntime type: ignore
77e5aae 
Pre-existing mypy errors: onnxruntime is excluded from install
(--no-extra cuda) so import-not-found needs to be ignored alongside
import-untyped.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeff-hykin @claude
fix: remove section markers from hello_docker.py and untrack .venv
e1f91be 
- Remove comment section markers (dashed lines) that violate the
  no-section-markers test policy
- Remove .venv symlink from git tracking (already in .gitignore)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jeff-hykin @claude
style: fix formatting in hello_docker.py
f83ed51 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
paul-nechifor
paul-nechifor reviewed Mar 15, 2026
View reviewed changes
examples/docker_hello_world/hello_docker.py Outdated
@rpc
def start(self) -> None:
super().start()
self.prompt.subscribe(self._on_prompt)
Copy link
Contributor

@paul-nechifor paul-nechifor Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example code should always follow best practices because people/LLMs are going to copy it. So in this case, you need to add to _disposables.

paul-nechifor
paul-nechifor reviewed Mar 15, 2026
View reviewed changes
examples/docker_hello_world/hello_docker.py Outdated
Comment on lines +74 to +80
result = subprocess.run(
["/usr/games/cowsay", text],
capture_output=True,
text=True,
check=True,
)
return result.stdout
Copy link
Contributor

@paul-nechifor paul-nechifor Mar 15, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result = subprocess.run(
["/usr/games/cowsay", text],
capture_output=True,
text=True,
check=True,
)
return result.stdout
return subprocess.check_output(["cowsay", text], text=True)

paul-nechifor
paul-nechifor reviewed Mar 15, 2026
View reviewed changes
examples/docker_hello_world/hello_docker.py Outdated


if __name__ == "__main__":
from dimos.core.blueprints import autoconnect
Copy link
Contributor

@paul-nechifor paul-nechifor Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move to top.

jeff-hykin and others added 16 commits March 14, 2026 18:49
@jeff-hykin
fix: address review comments on hello_docker example
51db86b 
- Add proper _disposables cleanup for stream subscriptions
- Use subprocess.check_output instead of subprocess.run
- Move inline import (autoconnect) to top of file
@jeff-hykin
fix: resolve merge conflict with dev (uv.lock)
7e9762a
@jeff-hykin
make timeout not hardcoded
044c9b9
@jeff-hykin
docs: add clarifying comment for deploy_parallel lambda tuple
53d2157
@jeff-hykin
feat: port rpc_timeouts system from jeff/fix/rosnav3
944701a 
- Module.rpc_timeouts dict allows per-method timeout overrides
- RPCClient resolves timeouts from module's rpc_timeouts, with defaults:
  start=1200s, everything else=120s
- RpcCall carries resolved timeout, passes it to call_sync
- DockerModule mirrors the same pattern via _resolve_timeout()
- call_sync no longer auto-detects 'start' — caller is responsible
- Pickle compat: RpcCall supports both old 2-tuple and new 3-tuple state
@jeff-hykin
Merge branch 'jeff/fix/docker3' of github.com:dimensionalOS/dimos int…
e1bf7bb 
…o jeff/fix/docker3
@jeff-hykin @github-actions
CI code cleanup
0719eeb
@jeff-hykin
fixup rpc timeouts, cause they matter for docker
3b4a4a1
@jeff-hykin
Merge branch 'dev' of github.com:dimensionalOS/dimos into jeff/fix/do…
a09439f 
…cker3
@jeff-hykin
better matching logic for rpc_timeouts
f219707
@jeff-hykin
enforce RPCSpec's to have rpc_timeouts in constructor
1289a63
@jeff-hykin @claude
Remove pr-name-check from this branch
d11312f 
Not related to rosnav feature work.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jeff-hykin
fixup rpc timeouts
0006eaf
@jeff-hykin
mypy issue on dev
f6e2273
@jeff-hykin
equality
64b5539
@jeff-hykin
Merge branch 'jeff/fix/docker3' of github.com:dimensionalOS/dimos int…
73a4e21 
…o jeff/fix/docker3
jeff-hykin
jeff-hykin commented Mar 15, 2026
View reviewed changes
pyproject.toml
"open3d>=0.18.0; platform_system != 'Linux' or platform_machine != 'aarch64'",
# these below should be removed later, right now they are needed even for running `dimos --help` (seperate non-docker issue)
"langchain-core",
"matplotlib",
Copy link
Member Author

@jeff-hykin jeff-hykin Mar 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should get fixed by #1571

@jeff-hykin
feat(native): add rebuild-on-change for NativeModule
d2e9446 
Add a generic file change detection utility (dimos/utils/change_detect.py)
that tracks content hashes via xxhash and integrate it into NativeModule so
it can automatically rebuild when watched source files change.

- change_detect.did_change() hashes file content, stores per-cache-name
  hash files in the venv, and returns True when files differ
- NativeModuleConfig gains rebuild_on_change: list[str] | None
- NativeModule._maybe_build() deletes stale executables when sources change
- 11 tests for change_detect, 3 integration tests for native rebuild
@jeff-hykin
normal path
b7e4821
@jeff-hykin
Merge branch 'jeff/feat/native_rebuild' of github.com:dimensionalOS/d…
738c600 
…imos into jeff/fix/docker3
@jeff-hykin
Revert "Merge branch 'jeff/feat/native_rebuild' of github.com:dimensi…
acd1f39 
…onalOS/dimos into jeff/fix/docker3"

This reverts commit 738c600, reversing
changes made to b7e4821.
@jeff-hykin
fix(rpc): explicitly call RPCClient.__init__ in RPCSpec
a87f576 
Protocol.__init__ bodies are unreachable via super() in the MRO,
so RPCClient.__init__ never ran — rpc_timeouts/default_rpc_timeout
were never set. Call it directly instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paul-nechifor paul-nechifor paul-nechifor left review comments

@JalajShuklaSS JalajShuklaSS JalajShuklaSS left review comments

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeff-hykin @paul-nechifor @JalajShuklaSS @spomichter