fix: reuse TCP connection instead of reconnecting on every tool call#1
Open
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Open
fix: reuse TCP connection instead of reconnecting on every tool call#1Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Conversation
Previously each callTool invocation opened a new TCP connection and re-ran the MCP initialize handshake. For robot control workloads with frequent tool calls this added significant latency. This change introduces a persistent connection pool keyed by host:port that initializes once and multiplexes subsequent requests with incrementing IDs. Connections auto-recover on close/error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
McpConnection) keyed byhost:portthat initializes the MCP session once and reuses it for all subsequenttools/callrequestsMotivation
Previously every
callToolinvocation opened a new TCP socket and ran the fullinitialize→tools/callhandshake. For robot control workloads that issue frequent tool calls, this added ~2 round-trips of unnecessary latency per call and wasted server resources.Test plan