fix: add try-catch around JSON.parse to prevent crashes on malformed data#2
Open
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Open
fix: add try-catch around JSON.parse to prevent crashes on malformed data#2Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Conversation
…ormed data The TCP data handler and child process script both called JSON.parse without error handling. If the MCP server sends malformed or partial JSON, the process would crash with an unhandled exception. Now malformed lines are skipped gracefully, and the discovery response parse gives a clear error message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JSON.parsein thecallToolTCP data handler with try-catch — malformed lines are now skipped instead of crashing the processJSON.parsefor the same reasonJSON.parse(result)indiscoverToolsSyncwith a descriptive error message showing the raw output on failureMotivation
If the DimOS MCP server sends partial, corrupted, or non-JSON data over the TCP stream, the unguarded
JSON.parsewould throw an unhandled exception and crash the entire plugin host process.Test plan