fix: pass host/port via env vars to prevent child process injection#3
Open
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Open
fix: pass host/port via env vars to prevent child process injection#3Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Conversation
…hild process The discoverToolsSync function previously interpolated host and port directly into a script string executed via execFileSync. While host was escaped with JSON.stringify, port was interpolated as a raw number. If type checking were bypassed, this could allow script injection. Now both values are passed as environment variables (MCP_HOST, MCP_PORT) which eliminates any interpolation-based injection risk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hostandportin the child process script with environment variables (MCP_HOST,MCP_PORT)Motivation
The
discoverToolsSyncfunction interpolatedportas a raw number andhostviaJSON.stringifydirectly into a Node.js script string passed toexecFileSync. Whilehostwas escaped,portwas not — if the type guard ingetPortwere bypassed (e.g. via a malformed config), arbitrary code could be injected into the child process.Using environment variables is inherently safe since they are never evaluated as code.
Test plan