test: add unit tests for config helpers and schema conversion#5
Open
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Open
test: add unit tests for config helpers and schema conversion#5Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Alex647648 wants to merge 1 commit intodimensionalOS:masterfrom
Conversation
Add vitest as dev dependency and create comprehensive unit tests covering config resolution and JSON Schema to TypeBox conversion. Export the pure utility functions to make them testable. 15 test cases covering: default/custom config values, all schema types (string, number, integer, boolean, array, object), required vs optional properties, and unknown type fallback behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitestas dev dependency withpnpm testscriptgetHost,getPort,jsonSchemaToTypeboxfor testabilityindex.test.tswith 15 test cases covering:getHost: default, invalid config, custom hostgetPort: default, invalid config, custom portjsonSchemaToTypebox: empty/undefined input, string/number/integer/boolean/array/object types, required vs optional marking, unknown type fallbackMotivation
The project had zero tests. These cover the pure utility functions that are most likely to regress during refactoring, especially the schema conversion logic which handles many type variants.
Test plan
pnpm test— 15/15 tests pass