Update snap to ground documentation to match implementation #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThierryBerger
approved these changes
Apr 4, 2025
Contributor
ThierryBerger
left a comment
ThierryBerger
left a comment
There was a problem hiding this comment.
Thanks, I'm approving ; I'm linking dimforge/rapier#481 though to remember switching that back if we end up changing the behaviour.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm writing a game that makes use of rapier, and I was scratching my head for quite a while trying to figure out why snap to ground wasn't working. Turned out to be because of this line of code. Whereas the docs say that snapping to ground requires no up component, the implementation actually requires it to be less than
-1e-5. I had been setting it to 0 when grounded, thus the confusion.