Add a customizable global error handler #825
Open
+157
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThierryBerger
commented
Apr 18, 2025
| if proxy.aabb.mins[dim] < self.max_bound { | ||
| default_error_handler()(Error::SapAxisInsert(format!( | ||
| "proxy.aabb.mins {} (in {:?}) <= max_bound {}", | ||
| proxy.aabb.mins[dim], proxy.aabb, self.max_bound |
Contributor
Author
There was a problem hiding this comment.
store values rather than string (proxy.abb, dim, max_bounds)
ThierryBerger
commented
Apr 18, 2025
| // TODO: add more context: | ||
| // - offending rigidbody ? | ||
| // - backtrace ? | ||
| assert!(tx.send(1).is_ok()); |
Contributor
Author
There was a problem hiding this comment.
TODO: send the error
Contributor
|
I would much rather see these errors propagated upwards where they occur. We don't need to replicate 1980s style error handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows user to react to an engine error, be it panic or try to fix the problem.
Took inspiration from https://github.com/bevyengine/bevy/blob/main/crates/bevy_ecs/src/error/handler.rs.
Current Status
Proof of concept is here, I'd like to add an example or test where user code is fixing an issue (removes a rigidbody ?)
More errors should probably be added in there.
Should this be behind a feature flag ?
no-std should be accounted for: be it allow it (custom oncelock), or not supporting it.