Add mapLeaves operation to Tree#108
Merged
Merged
Conversation
Collaborator
Author
|
Last commit implements #87 in new TensorTree and FloatTree. |
marcelluethi
approved these changes
May 25, 2026
Contributor
marcelluethi
left a comment
There was a problem hiding this comment.
Thanks for the change. I suppose this supersedes #87, which then could be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add mapLeaves operation to Tree (similar to jax.tree_util.tree_leaves).
General Motivation: Add reduce operation over a TensorTree structure.
Specific Motivation: Calculate Gradient Norm for Gradient Clipping (GPT-2 in deepwit).
This PR adds mapLeaves to TensorTree and FloatTree, which is similar to jax.tree_util.tree_leaves from JAX.
Difference to JAX: jax.tree_util.tree_leaves just returns a List of Any (without mapping), which makes less sense in a strongly typed language. Therefore, we require a mapping function f: [T <: Tuple, V] => (Labels[T]) ?=> (Tensor[T, V] => A) to unify all leaves (tensors) to a shared type A. Reduction across A can then be done on the Iterator[A] object.
Note: