[Accessibility] Use id instead of children #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi, this PR would solve the accessibility findings in our project. Will this be merged in the near future? Would be really appreciated! |
|
Same as @felix-schaffernicht-syzygy , merging this in will help address our accessibility issues when using it! |
|
Hey @UltimateGG, this is great thanks! I'm not involved in this project but it looks like you have tests failing if you look at https://github.com/pacocoursey/cmdk/pull/254/files. I wonder if we get those fixed if this will get some attention. @pacocoursey I'd be happy to pitch in here since accessibility is broken outright at the moment. Let me know how I can assist! Thanks! |
pacocoursey
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #253
Values were not being read aloud when selected with mouse, arrow keys, etc.
This is because:
aria-activedescendantwas not being updatedaria-activedescendantmust be focused to read the value it references aloudFinding the selected item was previously done using a querySelector and encodeUri which is bad because if children are used instead of a string, this will not serialize well (As well as spaces, special characters, etc.). The new approach is more robust and uses the actual ID in the dom.
The focus issue is solved by changing the focus back to the command input, or outer list container when the value is updated.